We have a clippy config for disallowing types:
|
disallowed-types = [ |
|
{ path = "std::time::Instant", reason = "Use `datafusion_common::instant::Instant` instead for WASM compatibility" }, |
|
] |
In datafusion-common we re-export hashbrown hashmaps/hashsets to encourage usage of them over std versions:
|
// The HashMap and HashSet implementations that should be used as the uniform defaults |
|
pub type HashMap<K, V, S = DefaultHashBuilder> = hashbrown::HashMap<K, V, S>; |
|
pub type HashSet<T, S = DefaultHashBuilder> = hashbrown::HashSet<T, S>; |
|
pub mod hash_map { |
|
pub use hashbrown::hash_map::Entry; |
|
} |
|
pub mod hash_set { |
|
pub use hashbrown::hash_set::Entry; |
|
} |
Consider using clippy to enforce this?
We have a clippy config for disallowing types:
datafusion/clippy.toml
Lines 6 to 8 in 3ea21aa
In
datafusion-commonwe re-export hashbrown hashmaps/hashsets to encourage usage of them over std versions:datafusion/datafusion/common/src/lib.rs
Lines 113 to 121 in 3ea21aa
Consider using clippy to enforce this?