[Vmware] Use host FQDN if host IP is not found on VNC command#5414
[Vmware] Use host FQDN if host IP is not found on VNC command#5414nvazquez wants to merge 2 commits intoapache:mainfrom
Conversation
|
@blueorangutan package |
|
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1151 |
|
@blueorangutan package |
|
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1152 |
|
@blueorangutan test centos7 vmware-67u3 |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests |
|
@blueorangutan test centos7 vmware-70 |
|
@rhtyd unsupported parameters provided. Supported mgmt server os are: |
| return false; | ||
| } | ||
|
|
||
| private String getHostFqdn(HostMO hostMO, String hostName) { |
There was a problem hiding this comment.
@nvazquez I think, it is better to keep this method in HostMO.
public String getHostFqdn() {
try {
HostDnsConfig hostDnsConfig = getHostNetworkInfo().getDnsConfig();
return String.format("%s.%s", hostDnsConfig.getHostName(), hostDnsConfig.getDomainName());
} catch (Exception e) {
s_logger.error("Could not get host FQDN for host: " + getHostName());
}
return null;
}
|
I'm closing this in favour of #5419 |
|
Trillian test result (tid-1988)
|
Description
This PR uses the host name if the host IP is not found on Vmware for Vmware 7 console proxy websocket URL
Fixes: #5413
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?