Skip to content

db upgrade: use "create or replace view" instead of "alter view"#4533

Merged
yadvr merged 1 commit intoapache:4.14from
ustcweizhou:4.14-create-or-replace-view
Dec 14, 2020
Merged

db upgrade: use "create or replace view" instead of "alter view"#4533
yadvr merged 1 commit intoapache:4.14from
ustcweizhou:4.14-create-or-replace-view

Conversation

@ustcweizhou
Copy link
Contributor

@ustcweizhou ustcweizhou commented Dec 11, 2020

Description

I faced an old issue when I upgrade cloudstack which database is restored from backup, and got the error in upgrade

2020-12-10 06:36:22,252 ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:) java.sql.SQLSyntaxErrorException: Access denied; you need (at least one of) the SUPER privilege(s) for this operation
2020-12-10 06:36:22,255 ERROR [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Unable to execute upgrade script
java.sql.SQLSyntaxErrorException: Access denied; you need (at least one of) the SUPER privilege(s) for this operation
        at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:185)
        at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:87)
        at com.cloud.upgrade.DatabaseUpgradeChecker.runScript(DatabaseUpgradeChecker.java:201)
        at com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(DatabaseUpgradeChecker.java:256)
        at com.cloud.upgrade.DatabaseUpgradeChecker.check(DatabaseUpgradeChecker.java:340)

see more info at http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201310.mbox/%3CCAM9eXO7nJOYmcZE=gte-1AiB+o8ZDtz7KuMEcy6mL-oovCUFBQ@mail.gmail.com%3E

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@ustcweizhou
db upgrade: fix sql exception: Access denied; you need (at least one …
e309be7 
…of) the SUPER privilege(s) for this operation
@yadvr
Copy link
Member

yadvr commented Dec 11, 2020

@weizhouapache do you think this is a blocker for 4.15?

@weizhouapache
Copy link
Member

weizhouapache commented Dec 11, 2020

@weizhouapache do you think this is a blocker for 4.15?

@rhtyd no ,it is not a blocker

@yadvr yadvr added this to the 4.14.1.0 milestone Dec 11, 2020
DaanHoogland
DaanHoogland approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old files but yes, valid changes

@yadvr
Copy link
Member

yadvr commented Dec 13, 2020

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Dec 13, 2020

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Dec 13, 2020

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2486

@yadvr
Copy link
Member

yadvr commented Dec 13, 2020

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Dec 13, 2020

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Dec 13, 2020

Trillian test result (tid-3345)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32820 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4533-t3345-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@yadvr yadvr merged commit 96cfe27 into apache:4.14 Dec 14, 2020
qrry added a commit to qrry/cloudstack that referenced this pull request Dec 23, 2020
@qrry
Merge branch 'master' into dev
7b74988 
* master:
  server: add conditions for custom offerings (apache#4540)
  vr: Ensuring dnsmasq.leases file is populated (apache#4529)
  template: Ensuring template is cross zone if type changed to system (apache#4522)
  storage: Fix hypervisor type cast to string (apache#4516)
  db upgrade: fix sql exception: Access denied; you need (at least one of) the SUPER privilege(s) for this operation (apache#4533)
  CLOUDSTACK-10423:Potential sensitive information disclosure (apache#4536)
  jobs: The patch remove the password from resultObject and make it be humanreadable (apache#4538)
  listphysicalnetworks: Honouring keyword parameter (apache#4511)
  Fix NPE when Volume exists on secondary store but doesn't have a download URL (apache#4530)
  apidoc issue (apache#4532)
  db: Fix description of volume.stats.interval which is in milliseconds not seconds (apache#4526)
  kvm: set cpu topology only if cpucore per socket is positive value (apache#4527)
  xenserver: check and eject patch vbd for systemvms (apache#4525)
  Fix warning when setup cloudstack-common (apache#4523)
  kvm: FIX cpucorespersocket is not working on KVM (apache#4497)
  change debug to warn for unknown exceptions (apache#4521)
  Fix failure in validating IP address in case of multiple Management Servers (apache#4507)
  Update log output for FirstFitPlanner (apache#4515)
  ui: deprecate old UI and move to legacy to be served at /client/legacy (apache#4518)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.14.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ustcweizhou @yadvr @weizhouapache @blueorangutan @DaanHoogland