ui: deprecate old UI and move to legacy to be served at /client/legacy#4518
ui: deprecate old UI and move to legacy to be served at /client/legacy#4518yadvr merged 3 commits intoapache:masterfrom
Conversation
As notified in the 4.14.0.0 release notes, this deprecates the legacy UI and moves it under the ui/legacy directory which will be served at /client/legacy URL path. This will also ensure that users upgrading or installing 4.15.0.0 will get the new UI by default. This will also make it simpler to remove the old UI for future 4.16/master releases. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr
requested review from
DaanHoogland,
GabrielBrascher,
PaulAngus,
Pearl1594,
davidjumani,
harikrishna-patnala,
sureshanaparti,
weizhouapache and
wido
|
This is strictly UI only change, screenshots: I'll add details on what we're doing here on the on-going email thread on dev@ ML later today. |
|
Basic sanitation check: |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
|
||
| <!-- Load this script after all scripts have executed to populate data --> | ||
| <script type="text/javascript" src="scripts/postLoad.js"></script> | ||
| <p>The legacy UI has been deprecated in this version as notified in the <a href="http://docs.cloudstack.apache.org/en/4.14.0.0/releasenotes/about.html#new-user-interface-depreciation-notice-of-existing-ui">previous release</a>. The legacy UI will be <a href="http://docs.cloudstack.apache.org/en/4.15.0.0/releasenotes/about.html#primate-ga-and-legacy-ui-deprecation-and-removal-notice">removed in the next release</a>.<br/>To access the legacy UI <a href="legacy">click here</a>.</p> |
There was a problem hiding this comment.
I wouldn't even make it a link, justr the instruction "add '/lagacy' to the url in your browser"
There was a problem hiding this comment.
Actually most users won't see this as the new UI (Primate) will get installed over the folder overwriting this index.html with its own.
| <link type="text/css" rel="stylesheet" href="css/custom.css" /> | ||
| </head> | ||
| <body> | ||
| <!-- CloudStack widget content --> |
There was a problem hiding this comment.
should we add a big deprecation banner here as well?
There was a problem hiding this comment.
I think we could, let me see if I can put something together.
|
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2460 |
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
|
Thanks @wido @DaanHoogland I've added the banner, can you review: |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
GabrielBrascher
left a comment
GabrielBrascher
left a comment
There was a problem hiding this comment.
Thanks for the changes @rhtyd!
LGTM
|
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2462 |
|
Did several tests, UI works OK after moving to legacy/ path. I'll merge this to test the bundling of primate build with 4.15/master pkgs next. Merging based on 2 lgtms and manual testing. |
|
Trillian test result (tid-3309)
|
* master: server: add conditions for custom offerings (apache#4540) vr: Ensuring dnsmasq.leases file is populated (apache#4529) template: Ensuring template is cross zone if type changed to system (apache#4522) storage: Fix hypervisor type cast to string (apache#4516) db upgrade: fix sql exception: Access denied; you need (at least one of) the SUPER privilege(s) for this operation (apache#4533) CLOUDSTACK-10423:Potential sensitive information disclosure (apache#4536) jobs: The patch remove the password from resultObject and make it be humanreadable (apache#4538) listphysicalnetworks: Honouring keyword parameter (apache#4511) Fix NPE when Volume exists on secondary store but doesn't have a download URL (apache#4530) apidoc issue (apache#4532) db: Fix description of volume.stats.interval which is in milliseconds not seconds (apache#4526) kvm: set cpu topology only if cpucore per socket is positive value (apache#4527) xenserver: check and eject patch vbd for systemvms (apache#4525) Fix warning when setup cloudstack-common (apache#4523) kvm: FIX cpucorespersocket is not working on KVM (apache#4497) change debug to warn for unknown exceptions (apache#4521) Fix failure in validating IP address in case of multiple Management Servers (apache#4507) Update log output for FirstFitPlanner (apache#4515) ui: deprecate old UI and move to legacy to be served at /client/legacy (apache#4518)
5 participants
As notified in the 4.14.0.0 release notes, this deprecates the legacy UI
and moves it under the ui/legacy directory which will be served at
/client/legacy URL path. This will also ensure that users upgrading or
installing 4.15.0.0 will get the new UI by default. This will also make
it simpler to remove the old UI for future 4.16/master releases.
The removal notice has been added here: https://github.com/apache/cloudstack-documentation/blob/master/source/releasenotes/about.rst#primate-ga-and-legacy-ui-deprecation-and-removal-notice
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity