Skip to content

Keeping consistency with other error messages.#11649

Merged
DaanHoogland merged 2 commits intoapache:mainfrom
daviftorres:Cleanup-error-messages-
Nov 11, 2025
Merged

Keeping consistency with other error messages.#11649
DaanHoogland merged 2 commits intoapache:mainfrom
daviftorres:Cleanup-error-messages-

Conversation

@daviftorres
Copy link
Contributor

@daviftorres daviftorres commented Sep 16, 2025 •
edited
Loading

Description

This PR makes trivial changes to the strings that are presented top the UI users.

While investigating a mysterious issue this message trough me off rails, chasing a possible heading or trailing space character.

image

I searched how this throws were presented in the code and realized this is probably how it should be presented.

image

It was easy to spot a few other occasions of the same pattern.

I am sorry if this sounds irrelevant but I hope this helps others.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Sep 16, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.55%. Comparing base (8c86f24) to head (329a2e3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ser/loadbalancer/UpdateLBHealthCheckPolicyCmd.java 0.00% 1 Missing ⚠️
...user/loadbalancer/UpdateLBStickinessPolicyCmd.java 0.00% 1 Missing ⚠️
...k/api/command/user/vpn/UpdateVpnConnectionCmd.java 0.00% 1 Missing ⚠️
...tack/api/command/user/vpn/UpdateVpnGatewayCmd.java 0.00% 1 Missing ⚠️
.../src/main/java/com/cloud/vm/dao/UserVmDaoImpl.java 0.00% 1 Missing ⚠️
.../main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java 0.00% 1 Missing ⚠️
...ain/java/com/cloud/api/query/QueryManagerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #11649      +/-   ##
============================================
- Coverage     17.55%   17.55%   -0.01%     
+ Complexity    15543    15538       -5     
============================================
  Files          5910     5910              
  Lines        529334   529334              
  Branches      64654    64654              
============================================
- Hits          92944    92905      -39     
- Misses       425933   425973      +40     
+ Partials      10457    10456       -1
Flag Coverage Δ
uitests 3.58% <ø> (ø)
unittests 18.61% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jbampton
Copy link
Member

jbampton commented Sep 16, 2025

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Sep 16, 2025

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Sep 16, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15046

harikrishna-patnala
harikrishna-patnala approved these changes Sep 17, 2025
View reviewed changes
Copy link
Member

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@harikrishna-patnala harikrishna-patnala added this to the 4.22.0 milestone Sep 17, 2025
DaanHoogland
DaanHoogland reviewed Sep 17, 2025
View reviewed changes
bernardodemarco
bernardodemarco reviewed Sep 21, 2025
View reviewed changes
vishesh92
vishesh92 approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Minor string changes only.

@vishesh92
Copy link
Member

vishesh92 commented Oct 13, 2025

@bernardodemarco IMO, we should address the ID to the UUID change in a separate PR. It needs to be changed at many places. As @DaanHoogland mentioned here, I also believe that we should have a better way to handle this.

@DaanHoogland DaanHoogland mentioned this pull request Oct 14, 2025
Merged
12 tasks
@DaanHoogland
Copy link
Contributor

DaanHoogland commented Nov 6, 2025

ping @bernardodemarco , can you concur with this given further work is done (in #11824 )?

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Nov 6, 2025

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Nov 6, 2025

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

bernardodemarco
bernardodemarco approved these changes Nov 6, 2025
View reviewed changes
Copy link
Member

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@blueorangutan
Copy link

blueorangutan commented Nov 6, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15664

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Nov 7, 2025

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Nov 7, 2025

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Davi Torres and others added 2 commits November 10, 2025 11:05
@daviftorres daviftorres force-pushed the Cleanup-error-messages- branch from 0d7fd0b to 329a2e3 Compare November 10, 2025 16:05
@DaanHoogland DaanHoogland modified the milestones: 4.22.0, 4.22.1 Nov 11, 2025
@DaanHoogland DaanHoogland changed the base branch from main to 4.22 November 11, 2025 08:22
@DaanHoogland DaanHoogland changed the base branch from 4.22 to main November 11, 2025 08:23
@DaanHoogland DaanHoogland modified the milestones: 4.22.1, 4.23 Nov 11, 2025
@DaanHoogland DaanHoogland merged commit 40c8bc5 into apache:main Nov 11, 2025
26 of 28 checks passed
ribafish added a commit to ribafish/apache-cloudstack that referenced this pull request Nov 14, 2025
@ribafish
Merge branch 'main' into gk/develocityIntegration
2f8416d 
* main: (1223 commits)
  Standardize and auto add license headers for SQL files with pre-commit (apache#12071)
  pre-commit use colored text in the CI for `pass / fail / skipped` (apache#11977)
  ui(locales): remove duplicates and fix typos (apache#11872)
  pre-commit: auto add table of contents with `doctoc` (apache#11679)
  chore: rename workflow `linter.yml` to `pre-commit.yml` (apache#11647)
  engine-schema: upgrade path for 4.23.0 (apache#12048)
  Fixes:apache#7837: Add isolationMethods and vlan to TrafficTypeResponse (apache#8151)
  Svgs (apache#12051)
  Update GUI Kubernetes logo (apache#11895)
  Keeping consistency with other error messages. (apache#11649)
  enhancement: add instance info as Libvirt metadata (apache#11061)
  Add empty Provider value in Network/VPC Offering form (apache#11982)
  merge fix
  Updating pom.xml version numbers for release 4.23.0.0-SNAPSHOT
  Updating pom.xml version numbers for release 4.22.1.0-SNAPSHOT
  UI: fix typo Upload SSL certificate (apache#11869)
  api/test: fix storage pool update with only id (apache#11897)
  Updating pom.xml version numbers for release 4.22.0.0
  Handle null mountTimeout in RestoreBackupCommand (apache#11944)
  Fix the config 'powerflex.connect.on.demand' description (apache#11926)
  ...
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Dec 11, 2025
@daviftorres @DaanHoogland @dhslove
Keeping consistency with other error messages. (apache#11649)
ba8f341 
Co-authored-by: Davi Torres <dtorres@simnet.ca>
Co-authored-by: dahn <daan.hoogland@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland left review comments

@harikrishna-patnala harikrishna-patnala harikrishna-patnala approved these changes

@vishesh92 vishesh92 vishesh92 approved these changes

@bernardodemarco bernardodemarco bernardodemarco approved these changes

Assignees

No one assigned

Labels

component:agent component:api component:build component:orchestration component:storage distro:ubuntu

Projects

None yet

Milestone

4.23.0

Development

Successfully merging this pull request may close these issues.

7 participants

@daviftorres @jbampton @blueorangutan @vishesh92 @DaanHoogland @harikrishna-patnala @bernardodemarco