ScaleIO/PowerFlex smoke tests improvements, and some fixes by sureshanaparti · Pull Request #11554 · apache/cloudstack

sureshanaparti · 2025-09-02T06:29:12Z

Description

This PR improves the smoke tests to support with ScaleIO/PowerFlex storage, and has some fixes.

It includes the following changes, in addition to the Marvin smoke tests.

Updates primary storage resource count for user vm volumes only, when change in size after volume is created on the storage pool. This resolves the resource count discrepancy. (Earlier VR volumes resource count for PowerFlex volumes is updated).
Updates disk bus type to SATA for UEFI enabled Windows VM with volume(s) on PowerFlex storage, on KVM hypervisor.
Adds support for volume metrics of PowerFlex/ScaleIO volumes of the VMs on KVM hypervisor (appropriate disk path is returned from the VM disk).
Updates the default value of 'powerflex.connect.on.demand' configuration to true.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Tested the updated smoke tests with ScaleIO/PowerFlex storage pool.

How did you try to break this feature and the system with this change?

sureshanaparti · 2025-09-02T06:30:03Z

@blueorangutan package

blueorangutan · 2025-09-02T06:32:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2025-09-02T06:37:27Z

Codecov Report

❌ Patch coverage is 11.11111% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.17%. Comparing base (9349b69) to head (0da4f27).
⚠️ Report is 13 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...stack/engine/orchestration/VolumeOrchestrator.java	0.00%	9 Missing ⚠️
...ervisor/kvm/resource/LibvirtComputingResource.java	0.00%	6 Missing and 1 partial ⚠️
.../cloud/resourcelimit/ResourceLimitManagerImpl.java	0.00%	3 Missing ⚠️
...atastore/driver/ScaleIOPrimaryDataStoreDriver.java	33.33%	2 Missing ⚠️
.../apache/cloudstack/metrics/MetricsServiceImpl.java	0.00%	1 Missing ⚠️
...src/main/java/com/cloud/server/StatsCollector.java	0.00%	1 Missing ⚠️
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #11554   +/-   ##
=========================================
  Coverage     16.17%   16.17%           
- Complexity    13294    13297    +3     
=========================================
  Files          5656     5656           
  Lines        498082   498090    +8     
  Branches      60415    60420    +5     
=========================================
+ Hits          80569    80580   +11     
+ Misses       408551   408545    -6     
- Partials       8962     8965    +3

Flag	Coverage Δ
uitests	`4.00% <ø> (ø)`
unittests	`17.03% <11.11%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2025-09-02T08:11:02Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14815

weizhouapache · 2025-09-02T08:49:57Z

@blueorangutan test

blueorangutan · 2025-09-02T08:52:06Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

weizhouapache

code lgtm

not tested yet

server/src/main/java/com/cloud/server/StatsCollector.java

blueorangutan · 2025-09-03T01:05:40Z

[SF] Trillian test result (tid-14183)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 54999 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11554-t14183-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

…lex)

…m volumes only The VR volumes resource count for PowerFlex volumes is updated here, resulting in resource count discrepancy (which is re-calculated through ResourceCountCheckTask later, and skips the VR volumes)

sureshanaparti · 2025-09-09T07:17:41Z

@blueorangutan package

blueorangutan · 2025-09-09T07:20:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

sureshanaparti · 2025-09-09T07:35:23Z

@blueorangutan package

blueorangutan · 2025-09-09T07:36:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-09-09T09:27:14Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14913

sureshanaparti · 2025-09-11T11:30:25Z

@blueorangutan test

blueorangutan · 2025-09-11T11:32:04Z

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-09-12T04:27:06Z

[SF] Trillian test result (tid-14295)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 57125 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11554-t14295-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

vladimirpetrov

LGTM, all smoke tests passed successfully with only powerflex primary storage.

Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_revert_vm_snapshots | `Error` | 95.88 | test_vm_snapshot_kvm.py
test_01_webhook_deliveries | `Failure` | 9.70 | test_webhook_delivery.py

The failed tests were executed manually and passed successfully:

test_vm_snapshot_kvm

Test to create VM snapshots ... === TestName: test_01_create_vm_snapshots | Status : SUCCESS ===
ok
Test to revert VM snapshots ... === TestName: test_02_revert_vm_snapshots | Status : SUCCESS ===
ok
Test to delete vm snapshots ... === TestName: test_03_delete_vm_snapshots | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 3 tests in 640.467s

OK

test_webhook_delivery:

test_01_webhook_deliveries (tests.smoke.test_webhook_delivery.TestWebhookDelivery) ... === TestName: test_01_webhook_deliveries | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 1 test in 9.591s

OK

weizhouapache · 2025-09-12T14:17:05Z

Merging based on approvals and manual tests by @vladimirpetrov

boring-cyborg bot added component:integration-test component:kvm component:management-server component:marvin Python Warning... Python code Ahead! labels Sep 2, 2025

sureshanaparti changed the base branch from main to 4.20 September 2, 2025 06:29

sureshanaparti added the component:powerflex label Sep 2, 2025

weizhouapache approved these changes Sep 2, 2025

View reviewed changes

server/src/main/java/com/cloud/server/StatsCollector.java Show resolved Hide resolved

apache deleted a comment from blueorangutan Sep 3, 2025

sureshanaparti and others added 7 commits September 9, 2025 12:44

ScaleIO/PowerFlex smoke tests improvements, and some fixes

8c2c890

Fix test_volumes.py, encrypted volume size check (for powerflex volumes)

c1e8d2b

Fix test_over_provisioning.py (over provisioning supported for powerf…

364f422

…lex)

Update vm snapshot tests

d77c11c

Fix test_import_unmanage_volumes.py (unsupported for powerflex)

e9e4238

Fix test_sharedfs_lifecycle.py (volume size check for powerflex)

b824cb3

sureshanaparti force-pushed the smoke-tests-improvements-for-scaleio_powerflex branch from 3b9a1b5 to 437dc8c Compare September 9, 2025 07:15

boring-cyborg bot added component:orchestration component:primary-storage component:storage labels Sep 9, 2025

Update powerflex.connect.on.demand config default to true

0da4f27

sureshanaparti force-pushed the smoke-tests-improvements-for-scaleio_powerflex branch from 437dc8c to 0da4f27 Compare September 9, 2025 07:33

vladimirpetrov approved these changes Sep 12, 2025

View reviewed changes

sureshanaparti marked this pull request as ready for review September 12, 2025 13:42

sureshanaparti added this to the 4.20.2 milestone Sep 12, 2025

weizhouapache merged commit 6d16ac2 into apache:4.20 Sep 12, 2025
25 of 26 checks passed

sureshanaparti deleted the smoke-tests-improvements-for-scaleio_powerflex branch September 12, 2025 14:20

sureshanaparti mentioned this pull request Oct 29, 2025

[PowerFlex] Fix the config 'powerflex.connect.on.demand' description #11926

Merged

14 tasks

Conversation

sureshanaparti commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

sureshanaparti commented Sep 2, 2025

Uh oh!

blueorangutan commented Sep 2, 2025

Uh oh!

codecov bot commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Sep 2, 2025

Uh oh!

weizhouapache commented Sep 2, 2025

Uh oh!

blueorangutan commented Sep 2, 2025

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

blueorangutan commented Sep 3, 2025

Uh oh!

sureshanaparti commented Sep 9, 2025

Uh oh!

blueorangutan commented Sep 9, 2025

Uh oh!

sureshanaparti commented Sep 9, 2025

Uh oh!

blueorangutan commented Sep 9, 2025

Uh oh!

blueorangutan commented Sep 9, 2025

Uh oh!

sureshanaparti commented Sep 11, 2025

Uh oh!

blueorangutan commented Sep 11, 2025

Uh oh!

blueorangutan commented Sep 12, 2025

Uh oh!

vladimirpetrov left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Sep 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sureshanaparti commented Sep 2, 2025 •

edited

Loading

codecov bot commented Sep 2, 2025 •

edited

Loading

vladimirpetrov left a comment •

edited

Loading