Skip to content

[CI][Dev] Fix shellcheck errors in the ci/scripts/python_test_emscripten.sh #47402

@hiroyuki-sato

Description

@hiroyuki-sato

Describe the enhancement requested

This is the sub issue #44748.

  • SC2086: Double quote to prevent globbing and word splitting
  • SC2012: Use find instead of ls to better handle non-alphanumeric filenames
shellcheck ci/scripts/python_test_emscripten.sh

In ci/scripts/python_test_emscripten.sh line 28:
cd ${build_dir}
   ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
cd "${build_dir}"


In ci/scripts/python_test_emscripten.sh line 31:
pyodide_wheel=$(ls -t dist/pyarrow*.whl | head -1)
                ^---------------------^ SC2012 (info): Use find instead of ls to better handle non-alphanumeric filenames.


In ci/scripts/python_test_emscripten.sh line 34:
python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=node
                                       ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                   ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=node


In ci/scripts/python_test_emscripten.sh line 37:
python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=chrome
                                       ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                   ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=chrome

For more information:
  https://www.shellcheck.net/wiki/SC2012 -- Use find instead of ls to better ...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

Component(s)

Continuous Integration

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions