Skip to content

Add overwrite parameter to IMAP hook to prevent silent file overwrites #65870#68838

Merged
vincbeck merged 3 commits into
apache:mainfrom
kada2004:usr/dank/firstcontri-
Jul 6, 2026
Merged

Add overwrite parameter to IMAP hook to prevent silent file overwrites #65870#68838
vincbeck merged 3 commits into
apache:mainfrom
kada2004:usr/dank/firstcontri-

Conversation

@kada2004

@kada2004 kada2004 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Hi maintainers, this is my first contribution to the project , so I may have missed something.
I thought this issue would be a good first one to work on, and I’m happy to make any changes based on your feedback. Thanks. Description down

When download mail attachments is called and multiple emails shared and attachments with the same filename, the existing file is silent overwritten.

This adds an overwrittten paramter ( default to True, preserving the current behavior). When set to False, duplicate filenames are renamed with a numeric suffix( Example. report_1.xlsx , report_2.xlsx) instead of overwriting).


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg

boring-cyborg Bot commented Jun 22, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@kada2004 kada2004 changed the title Add overwrite parameter to IMAP hook to prevent silent file overwrites Add overwrite parameter to IMAP hook to prevent silent file overwrites #65870 Jun 24, 2026
@eladkal
eladkal requested a review from shahar1 June 30, 2026 07:02
@potiuk potiuk added the ready for maintainer review Set after triaging when all criteria pass. label Jul 2, 2026
@vincbeck
vincbeck merged commit 5fb8637 into apache:main Jul 6, 2026
77 checks passed
@boring-cyborg

boring-cyborg Bot commented Jul 6, 2026

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:imap ready for maintainer review Set after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IMAP hook silently overwrites attachments with identical filenames

3 participants