Add 'overwrite' option to ImapHook.download_mail_attachments#65878
Closed
shashbha14 wants to merge 3 commits into
Closed
Add 'overwrite' option to ImapHook.download_mail_attachments#65878shashbha14 wants to merge 3 commits into
shashbha14 wants to merge 3 commits into
Conversation
added 2 commits
April 26, 2026 21:24
shashbha14
marked this pull request as ready for review
April 28, 2026 15:37
potiuk
added
the
ready for maintainer review
Contributor
|
Fixed in #68838 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #65870
At present, the method 'ImapHook.download_mail_attachments' silently overwrites existing files in the event that attachments are re-downloaded using the same filename.
This PR introduces an 'overwrite: bool = True' optional parameter to 'download_mail_attachments' (and its internal methods 'create_files' and '_create_file'). If 'False', a suffix is added to the filename ('file.csv' → 'file_1.csv') rather than overwriting.
The default is 'True' for backwards compatibility.
I utilized Claude (claude.ai) as my AI helper on parts of this implementation.