Partially enable TRY002 rule#38756
Merged
Merged
Conversation
Taragolis
requested review from
Lee-W,
eladkal,
ephraimbuddy,
ferruzzi,
hussein-awala,
jedcunningham,
potiuk,
uranusjr and
vincbeck
hussein-awala
approved these changes
Apr 4, 2024
ferruzzi
approved these changes
Apr 4, 2024
ferruzzi
left a comment
ferruzzi
left a comment
Contributor
There was a problem hiding this comment.
Left a grammar/phrasing suggestion and one non-blocking question.
Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com>
25 tasks
ephraimbuddy
added
the
changelog:skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final step after the similar PR
Enable
TRY002into the entire repo (except tests).This will forced to use Airflow specific exceptions or more suitable builtins instead of just to broad
ExceptionThere is 60 usage of Exception into the providers, so follow up task will be created after.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.