Skip to content

Replace to broad exceptions into the Core#38344

Merged
potiuk merged 1 commit into
apache:mainfrom
Taragolis:too-broad-exceptions-core
Mar 21, 2024
Merged

Replace to broad exceptions into the Core#38344
potiuk merged 1 commit into
apache:mainfrom
Taragolis:too-broad-exceptions-core

Conversation

@Taragolis

Copy link
Copy Markdown
Contributor

Replace extensive raise Exception by more generic and appropriate to the error.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg Bot added area:API Airflow's REST/HTTP API area:core-operators area:logging area:Scheduler including HA (high availability) scheduler area:webserver Webserver related Issues labels Mar 20, 2024
@Taragolis Taragolis added the full tests needed We need to run full set of tests for this PR to merge label Mar 20, 2024
@Taragolis Taragolis closed this Mar 20, 2024
@Taragolis Taragolis reopened this Mar 20, 2024

@hussein-awala hussein-awala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, LGTM

@potiuk potiuk merged commit 83e83e2 into apache:main Mar 21, 2024
@Taragolis Taragolis deleted the too-broad-exceptions-core branch March 21, 2024 09:04
@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API area:logging area:Scheduler including HA (high availability) scheduler area:webserver Webserver related Issues full tests needed We need to run full set of tests for this PR to merge type:improvement Changelog: Improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants