Skip to content

Remove click upper bound #32634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 2 commits into from
Jul 20, 2023
Merged

Remove click upper bound #32634

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
877210b
Remove click upper bound
pierrejeambrun Jul 16, 2023
0b48ede
Fix typo
pierrejeambrun Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ def git_version() -> str:

try:
repo = git.Repo(str(AIRFLOW_SOURCES_ROOT / ".git"))
except (git.NoSuchPathError):
except git.NoSuchPathError:
logger.warning(".git directory not found: Cannot compute the git version")
return ""
except git.InvalidGitRepositoryError:
Expand Down Expand Up @@ -266,9 +266,9 @@ def write_version(filename: str = str(AIRFLOW_SOURCES_ROOT / "airflow" / "git_ve
doc = [
"astroid>=2.12.3",
"checksumdir",
# Click 8.1.4 breaks our mypy checks. The upper limit can be lifted when the
# https://github.com/apache/airflow/issues/32412 issue is resolved
"click>=8.0,<8.1.4",
# click 8.1.4 and 8.1.5 generate mypy errors due to typing issue in the upstream package:
# https://github.com/pallets/click/issues/2558
"click>=8.0,!=8.1.4,!=8.1.5",
# Docutils 0.17.0 converts generated <div class="section"> into <section> and breaks our doc formatting
# By adding a lot of whitespace separation. This limit can be lifted when we update our doc to handle
# <section> tags for sections
Expand Down Expand Up @@ -515,12 +515,12 @@ def filter_out_excluded_extras() -> Iterable[tuple[str, list[str]]]:


def add_extras_for_all_providers() -> None:
for (provider_name, provider_dict) in PROVIDER_DEPENDENCIES.items():
for provider_name, provider_dict in PROVIDER_DEPENDENCIES.items():
EXTRAS_DEPENDENCIES[provider_name] = provider_dict[DEPS]


def add_additional_extras() -> None:
for (extra_name, extra_dependencies) in ADDITIONAL_EXTRAS_DEPENDENCIES.items():
for extra_name, extra_dependencies in ADDITIONAL_EXTRAS_DEPENDENCIES.items():
EXTRAS_DEPENDENCIES[extra_name] = extra_dependencies


Expand Down