Skip to content

Remove click upper bound#32634

Merged
potiuk merged 2 commits into
apache:mainfrom
pierrejeambrun:unpin-click
Jul 20, 2023
Merged

Remove click upper bound#32634
potiuk merged 2 commits into
apache:mainfrom
pierrejeambrun:unpin-click

Conversation

@pierrejeambrun

@pierrejeambrun pierrejeambrun commented Jul 16, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

closes: #32412

Remove upper bound limit on click, 8.1.6 is out with a fix:
https://click.palletsprojects.com/en/8.1.x/changes/

@pierrejeambrun pierrejeambrun added the type:misc/internal Changelog: Misc changes that should appear in change log label Jul 16, 2023
@pierrejeambrun pierrejeambrun added this to the Airflow 2.6.4 milestone Jul 16, 2023
@pierrejeambrun

pierrejeambrun commented Jul 16, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

Brings new mypy errors, I am taking a look.

https://github.com/apache/airflow/actions/runs/5568285742/jobs/10171191069?pr=32634

@pierrejeambrun

pierrejeambrun commented Jul 16, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

8.1.5 patch is not enough, tried locally with pallets/click#2565 and it seems to works. This will have to wait for 8.1.6

@uranusjr

uranusjr commented Jul 17, 2023

Copy link
Copy Markdown
Member

Converting to draft to avoid accidental merge.

@uranusjr uranusjr marked this pull request as draft July 17, 2023 05:29
@pierrejeambrun pierrejeambrun marked this pull request as ready for review July 18, 2023 23:25
@pierrejeambrun

pierrejeambrun commented Jul 18, 2023

Copy link
Copy Markdown
Member Author

Click 8.1.6 was just released, retrying the CI.

@pierrejeambrun pierrejeambrun marked this pull request as draft July 19, 2023 06:01
@pierrejeambrun pierrejeambrun marked this pull request as ready for review July 19, 2023 07:01
pankajkoti
pankajkoti approved these changes Jul 19, 2023
View reviewed changes

@pankajkoti pankajkoti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to update the PR description to reflect the updated click version that fixes the issue instead of the current mention for 8.1.5

@pierrejeambrun

pierrejeambrun commented Jul 19, 2023

Copy link
Copy Markdown
Member Author

We may need to update the PR description to reflect the updated click version that fixes the issue instead of the current mention for 8.1.5

Done, thanks

@potiuk

potiuk commented Jul 19, 2023

Copy link
Copy Markdown
Member

Should we make it >= 8.1.6 maybe ? I think there is no downside in requiring the newer version of click?

@potiuk

potiuk commented Jul 19, 2023

Copy link
Copy Markdown
Member

Or if there are, then specifically alexcluding those buggy version could be a good idea instead

@pierrejeambrun pierrejeambrun force-pushed the unpin-click branch 2 times, most recently from 6dce8c9 to 89a9851 Compare July 19, 2023 22:14
@pierrejeambrun

pierrejeambrun commented Jul 19, 2023

Copy link
Copy Markdown
Member Author

Or if there are, then specifically alexcluding those buggy version could be a good idea instead

Good idea, done. 8.1.4 and 8.1.5 are now excluded

@potiuk

potiuk commented Jul 20, 2023

Copy link
Copy Markdown
Member

random errors. merging.

@potiuk potiuk merged commit 7123dc1 into apache:main Jul 20, 2023
@pierrejeambrun pierrejeambrun deleted the unpin-click branch July 20, 2023 06:19
@eladkal eladkal modified the milestones: Airflow 2.6.4, Airflow 2.7.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes
@Lee-W Lee-W Lee-W approved these changes
@pankajkoti pankajkoti pankajkoti approved these changes
@hussein-awala hussein-awala hussein-awala approved these changes
@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy

Assignees

No one assigned

Labels

type:misc/internal Changelog: Misc changes that should appear in change log

Projects

None yet

Milestone

Airflow 2.7.0

Development

Successfully merging this pull request may close these issues.

Click 8.1.4 breaks mypy typing checks

7 participants

@pierrejeambrun @uranusjr @potiuk @Lee-W @pankajkoti @hussein-awala @eladkal