Fix hard-coded /tmp dir in sqlite_default#19255
Merged
Merged
Conversation
aran3
force-pushed
the
gettempdir_dbutil
branch
from
37c3c8a to
c3a0441
Compare
respecting tempdir enviroment variables. See apache#19208, apache#19229.
aran3
force-pushed
the
gettempdir_dbutil
branch
from
c3a0441 to
9c31b45
Compare
potiuk
approved these changes
Oct 27, 2021
github-actions
Bot
added
the
full tests needed
Contributor
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Member
|
Looks like all those failed tests were flaky :( Each of them different. Closed/reopened to check, |
|
Awesome work, congrats on your first merged pull request! |
jedcunningham
pushed a commit
that referenced
this pull request
Nov 3, 2021
This was referenced Nov 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sqlite_default has been hard-coded to /tmp, usegettempdir instead,
respecting tempdir enviroment variables.
See #19208, #19229.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.