Removes hard-coding of /tmp filesystem cache#19208
Merged
Merged
Conversation
Filesystem cache has been hard-coded to /tmp. This would not work for Windows but (more importantly) it does not work in case the user has no access to /tmp directory and TMPDIR is set to a different value. Fixes: apache#19206
2 tasks
Member
|
Can you also update: ? |
Member
Author
Should be done as separate PR I think. |
Member
Author
Merged
mik-laj
approved these changes
Oct 26, 2021
Contributor
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
Bot
added
the
okay to merge
sharon2719
pushed a commit
to sharon2719/airflow
that referenced
this pull request
Oct 27, 2021
Filesystem cache has been hard-coded to /tmp. This would not work for Windows but (more importantly) it does not work in case the user has no access to /tmp directory and TMPDIR is set to a different value. Fixes: apache#19206
aran3
added a commit
to aran3/airflow
that referenced
this pull request
Oct 27, 2021
respecting tempdir enviroment variables. See apache#19208, apache#19229.
potiuk
pushed a commit
that referenced
this pull request
Oct 27, 2021
jedcunningham
pushed a commit
that referenced
this pull request
Nov 3, 2021
This was referenced Nov 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filesystem cache has been hard-coded to /tmp. This would not
work for Windows but (more importantly) it does not work in case
the user has no access to /tmp directory and TMPDIR is set to
a different value.
Fixes: #19206
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.