Skip to content

Fix image retagging when pulling the images #18433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Sep 22, 2021
Merged

Fix image retagging when pulling the images #18433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/ci/images/ci_prepare_ci_image_on_ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ function build_ci_image_on_ci() {
md5sum::calculate_md5sum_for_all_files
local image_name_with_tag="${AIRFLOW_CI_IMAGE}:${GITHUB_REGISTRY_PULL_IMAGE_TAG}"
push_pull_remove_images::wait_for_image "${image_name_with_tag}"
docker_v tag "${image_name_with_tag}" "${AIRFLOW_CI_IMAGE}"
md5sum::update_all_md5_with_group
else
build_images::rebuild_ci_image_if_needed
Expand Down
1 change: 1 addition & 0 deletions scripts/ci/images/ci_prepare_prod_image_on_ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ function build_prod_images_on_ci() {
if [[ ${GITHUB_REGISTRY_WAIT_FOR_IMAGE} == "true" ]]; then
local image_name_with_tag="${AIRFLOW_PROD_IMAGE}:${GITHUB_REGISTRY_PULL_IMAGE_TAG}"
push_pull_remove_images::wait_for_image "${image_name_with_tag}"
docker_v tag "${image_name_with_tag}" "${AIRFLOW_PROD_IMAGE}"
else
build_images::build_prod_images_from_locally_built_airflow_packages
fi
Expand Down
2 changes: 2 additions & 0 deletions scripts/ci/images/ci_wait_for_and_verify_ci_image.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,5 @@ push_pull_remove_images::wait_for_image "${image_name_with_tag}"
if [[ ${VERIFY_IMAGE=} != "false" ]]; then
verify_image::verify_ci_image "${image_name_with_tag}"
fi

docker_v tag "${image_name_with_tag}" "${AIRFLOW_CI_IMAGE}"
2 changes: 2 additions & 0 deletions scripts/ci/images/ci_wait_for_and_verify_prod_image.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,5 @@ push_pull_remove_images::wait_for_image "${image_name_with_tag}"
if [[ ${VERIFY_IMAGE=} != "false" ]]; then
verify_image::verify_prod_image "${image_name_with_tag}"
fi

docker_v tag "${image_name_with_tag}" "${AIRFLOW_PROD_IMAGE}"