Fix image retagging when pulling the images#18433
Merged
Merged
Conversation
The change apache#17883 missed re-tagging images after downloading which caused unnecessary image rebuilding for PRs as well as using wrong image for doc building - previous version of docs were used when building docs!
potiuk
force-pushed
the
fix-image-retagging
branch
from
57386d3 to
7d7d2ef
Compare
mik-laj
approved these changes
Sep 22, 2021
Contributor
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
Bot
added
the
full tests needed
This was referenced Sep 22, 2021
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Sep 22, 2021
Recently we had a problem that our CI got broken because pulled images were not tagged properly after apache#17883 missed image tagging. This has been fixed in apache#18433 but the problem is that this might happen in the future and mignt not get noticed on time. This PR prevents from similar situations happnening. Whenever we try to run doc building or tests we set --pull policy to never for both docker and docker compose which should simply fail if the images were not pulled and tagged properly rather than fail over to pulling latest `main` image.
potiuk
added a commit
that referenced
this pull request
Sep 22, 2021
Recently we had a problem that our CI got broken because pulled images were not tagged properly after #17883 missed image tagging. This has been fixed in #18433 but the problem is that this might happen in the future and mignt not get noticed on time. This PR prevents from similar situations happnening. Whenever we try to run doc building or tests we set --pull policy to never for both docker and docker compose which should simply fail if the images were not pulled and tagged properly rather than fail over to pulling latest `main` image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change #17883 missed re-tagging images after downloading
which caused unnecessary image rebuilding for PRs as well as using
wrong image for doc building - previous version of docs were used
when building docs!
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.