Skip to content

Removing redundant relabeling of ADX conn field#18386

Merged
eladkal merged 1 commit into
apache:mainfrom
josh-fell:adx-conn-remove-relabel
Sep 25, 2021
Merged

Removing redundant relabeling of ADX conn field#18386
eladkal merged 1 commit into
apache:mainfrom
josh-fell:adx-conn-remove-relabel

Conversation

@josh-fell

Copy link
Copy Markdown
Contributor

In a previous PR (#18203) there was a change made to the relabeling of the password connection field from "Auth Password" to "Password". This relabeling should have been removed rather than updated as it is redundant.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@josh-fell josh-fell changed the title Removing redundant relabeling of password conn field Removing redundant relabeling of ADX conn field Sep 20, 2021
@josh-fell

josh-fell commented Sep 20, 2021

Copy link
Copy Markdown
Contributor Author

Will roll this into a later PR.

@josh-fell josh-fell closed this Sep 20, 2021
@josh-fell josh-fell deleted the adx-conn-remove-relabel branch September 20, 2021 21:20
@josh-fell josh-fell restored the adx-conn-remove-relabel branch September 21, 2021 13:24
@josh-fell josh-fell reopened this Sep 21, 2021
@github-actions

Copy link
Copy Markdown
Contributor

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions Bot added the okay to merge It's ok to merge this PR as it does not require more tests label Sep 25, 2021
@eladkal eladkal merged commit 4648446 into apache:main Sep 25, 2021
@josh-fell josh-fell deleted the adx-conn-remove-relabel branch September 27, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:microsoft-azure Azure-related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants