Proper handling of custom conn field values in the AzureDataExplorerHook#18203
Merged
Conversation
boring-cyborg
Bot
added
area:providers
provider:microsoft-azure
potiuk
approved these changes
Sep 18, 2021
56 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #18124
This PR addresses two main issues with the current
AzureDataExplorerHook:Azure Data Explorerconnection fields mappings forTenant IDandAuthentication Methodare switched so the hook cannot properly use the values specified.get_required_params()method is passed invalid values and will always raise an exception for a missing required parameter. These invalid values are from the classicExtrasfields in the connection form which is no longer exposed in theAzure Data Explorerconnection type.Additionally there are minor updates made to the hook's docstring for information accuracy and correct rendering of Airflow docs as well as small spelling/grammar changes.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.