Skip to content

Fix test bug introduced by #15165#15221

Merged
potiuk merged 1 commit into
apache:masterfrom
astronomer:fix-k8s-exec-tests
Apr 6, 2021
Merged

Fix test bug introduced by #15165#15221
potiuk merged 1 commit into
apache:masterfrom
astronomer:fix-k8s-exec-tests

Conversation

@dimberman

Copy link
Copy Markdown
Contributor

#15165 introduced a bug in the
kubernetes_executor tests. This fixes that bug by changing pytest mock


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

apache#15165 introduced a bug in the
kubernetes_executor tests. This fixes that bug by changing pytest mock
@boring-cyborg boring-cyborg Bot added the area:Scheduler including HA (high availability) scheduler label Apr 6, 2021
@github-actions

github-actions Bot commented Apr 6, 2021

Copy link
Copy Markdown
Contributor

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions Bot added the full tests needed We need to run full set of tests for this PR to merge label Apr 6, 2021
@potiuk

potiuk commented Apr 6, 2021

Copy link
Copy Markdown
Member

I tested it locally. Works. Merging it to rebase other changes.

@potiuk potiuk merged commit e1beefc into apache:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Scheduler including HA (high availability) scheduler full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants