Separate Kubernetes pod_launcher from core airflow#15165
Merged
Conversation
dimberman
requested review from
XD-DENG,
ashb,
kaxil and
turbaszek
as code owners
boring-cyborg
Bot
added
provider:cncf-kubernetes
Contributor
Author
|
cc: @SamWheating |
eladkal
reviewed
Apr 2, 2021
Comment on lines
26
to
28
Contributor
There was a problem hiding this comment.
Should we note in UPDATING.md that this class is deprecated?
Contributor
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
dimberman
force-pushed
the
refactor-k8s-operator
branch
2 times, most recently
from
8ddcf6c to
01b2f75
Compare
ashb
reviewed
Apr 3, 2021
Comment on lines
246
to
262
Member
There was a problem hiding this comment.
This is all the executor used the pod launcher for?!
I was expecting this to be a much bigger change
Contributor
Author
There was a problem hiding this comment.
@ashb It makes sense. The KubernetesExecutor is fire and forget. We don't monitor the task via the pod launcher for the KubernetesExecutor, just monitor the task state via the job watcher.
potiuk
reviewed
Apr 4, 2021
SamWheating
reviewed
Apr 5, 2021
dimberman
force-pushed
the
refactor-k8s-operator
branch
from
166c529 to
c91b2e2
Compare
kaxil
previously requested changes
Apr 5, 2021
dimberman
force-pushed
the
refactor-k8s-operator
branch
from
de374b3 to
883c55f
Compare
potiuk
requested changes
Apr 5, 2021
Member
There was a problem hiding this comment.
Should we also add the deprecation warning directly here (or even move the warning from the old pod_launcher)? This way even if someone by mistake imports PodLauncher/PodStatus directly from there (because IDE will provide this as first-class option), will still get the warning.
Contributor
Author
There was a problem hiding this comment.
@potiuk I added the deprecation to the deprecated class. good catch!
Member
There was a problem hiding this comment.
Yep.. Waiting for push to approve it ;)
Currently, the KubernetesPodOperator uses the pod_launcher class in airflow core. This means that if we need to fix a bug in the KubernetesPodOperator such as apache#15137 then the new cncf.kubernetes package will require an Airflow upgrade. Since we hope to release providers in a much faster cadence than Airflow core releases, we should separate this dependency.
dimberman
force-pushed
the
refactor-k8s-operator
branch
from
82e88b9 to
5d0b0ca
Compare
github-actions
Bot
added
the
okay to merge
Contributor
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
dimberman
added a commit
to astronomer/airflow
that referenced
this pull request
Apr 6, 2021
apache#15165 introduced a bug in the kubernetes_executor tests. This fixes that bug by changing pytest mock
potiuk
pushed a commit
that referenced
this pull request
Apr 6, 2021
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 17, 2021
apache/airflow#15165 introduced a bug in the kubernetes_executor tests. This fixes that bug by changing pytest mock GitOrigin-RevId: e1beefc1123ba340a2565c743a0723d135bfc3a3
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 23, 2021
apache/airflow#15165 introduced a bug in the kubernetes_executor tests. This fixes that bug by changing pytest mock GitOrigin-RevId: e1beefc1123ba340a2565c743a0723d135bfc3a3
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 27, 2021
apache/airflow#15165 introduced a bug in the kubernetes_executor tests. This fixes that bug by changing pytest mock GitOrigin-RevId: e1beefc1123ba340a2565c743a0723d135bfc3a3
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Mar 10, 2022
apache/airflow#15165 introduced a bug in the kubernetes_executor tests. This fixes that bug by changing pytest mock GitOrigin-RevId: e1beefc1123ba340a2565c743a0723d135bfc3a3
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jun 4, 2022
apache/airflow#15165 introduced a bug in the kubernetes_executor tests. This fixes that bug by changing pytest mock GitOrigin-RevId: e1beefc1123ba340a2565c743a0723d135bfc3a3
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jul 9, 2022
apache/airflow#15165 introduced a bug in the kubernetes_executor tests. This fixes that bug by changing pytest mock GitOrigin-RevId: e1beefc1123ba340a2565c743a0723d135bfc3a3
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Aug 27, 2022
apache/airflow#15165 introduced a bug in the kubernetes_executor tests. This fixes that bug by changing pytest mock GitOrigin-RevId: e1beefc1123ba340a2565c743a0723d135bfc3a3
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 4, 2022
apache/airflow#15165 introduced a bug in the kubernetes_executor tests. This fixes that bug by changing pytest mock GitOrigin-RevId: e1beefc1123ba340a2565c743a0723d135bfc3a3
aglipska
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 7, 2022
apache/airflow#15165 introduced a bug in the kubernetes_executor tests. This fixes that bug by changing pytest mock GitOrigin-RevId: e1beefc1123ba340a2565c743a0723d135bfc3a3
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Dec 7, 2022
apache/airflow#15165 introduced a bug in the kubernetes_executor tests. This fixes that bug by changing pytest mock GitOrigin-RevId: e1beefc1123ba340a2565c743a0723d135bfc3a3
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jan 27, 2023
apache/airflow#15165 introduced a bug in the kubernetes_executor tests. This fixes that bug by changing pytest mock GitOrigin-RevId: e1beefc1123ba340a2565c743a0723d135bfc3a3
kosteev
pushed a commit
to kosteev/composer-airflow-test-copybara
that referenced
this pull request
Sep 12, 2024
apache/airflow#15165 introduced a bug in the kubernetes_executor tests. This fixes that bug by changing pytest mock GitOrigin-RevId: e1beefc1123ba340a2565c743a0723d135bfc3a3
kosteev
pushed a commit
to kosteev/composer-airflow-test-copybara
that referenced
this pull request
Sep 12, 2024
apache/airflow#15165 introduced a bug in the kubernetes_executor tests. This fixes that bug by changing pytest mock GitOrigin-RevId: e1beefc1123ba340a2565c743a0723d135bfc3a3
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 17, 2024
apache/airflow#15165 introduced a bug in the kubernetes_executor tests. This fixes that bug by changing pytest mock GitOrigin-RevId: e1beefc1123ba340a2565c743a0723d135bfc3a3
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 7, 2024
apache/airflow#15165 introduced a bug in the kubernetes_executor tests. This fixes that bug by changing pytest mock GitOrigin-RevId: e1beefc1123ba340a2565c743a0723d135bfc3a3
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
May 1, 2025
apache/airflow#15165 introduced a bug in the kubernetes_executor tests. This fixes that bug by changing pytest mock GitOrigin-RevId: e1beefc1123ba340a2565c743a0723d135bfc3a3
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
May 22, 2025
apache/airflow#15165 introduced a bug in the kubernetes_executor tests. This fixes that bug by changing pytest mock GitOrigin-RevId: e1beefc1123ba340a2565c743a0723d135bfc3a3
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 17, 2025
apache/airflow#15165 introduced a bug in the kubernetes_executor tests. This fixes that bug by changing pytest mock GitOrigin-RevId: e1beefc1123ba340a2565c743a0723d135bfc3a3
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 15, 2025
apache/airflow#15165 introduced a bug in the kubernetes_executor tests. This fixes that bug by changing pytest mock GitOrigin-RevId: e1beefc1123ba340a2565c743a0723d135bfc3a3
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Feb 20, 2026
apache/airflow#15165 introduced a bug in the kubernetes_executor tests. This fixes that bug by changing pytest mock GitOrigin-RevId: e1beefc1123ba340a2565c743a0723d135bfc3a3
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Apr 24, 2026
apache/airflow#15165 introduced a bug in the kubernetes_executor tests. This fixes that bug by changing pytest mock GitOrigin-RevId: e1beefc1123ba340a2565c743a0723d135bfc3a3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the KubernetesPodOperator uses the pod_launcher class in airflow core. This means that if we need to fix a bug in the KubernetesPodOperator such as #15137 then the new cncf.kubernetes package will require an Airflow upgrade. Since we hope to release providers in a much faster cadence than Airflow core releases, we should separate this dependency.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.