Fixes broken asset compilation in Docker images#14995
Merged
Merged
Conversation
Member
Author
|
This one will need to be cherry-picked to 2.0.2 as well @kaxil |
kaxil
approved these changes
Mar 25, 2021
github-actions
Bot
added
the
full tests needed
Contributor
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Member
|
:( test is failing, this is the same error as #14968 (comment) |
Contributor
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
Contributor
|
The Workflow run is cancelling this PR. Building image for the PR has been cancelled |
potiuk
force-pushed
the
fix-removed-asset-recompilation
branch
2 times, most recently
from
c1ce886 to
4ab0abd
Compare
Contributor
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason. |
The change apache#14911 had a bug - when PYTHON_MINOR_MAJOR_VERSION was removed from the imge args, the replacement `python -m site` expression missed `/airflow/` suffix. Unfortunately it was not flagged as an error because the recompiling script silently skipped recompilation step in such case. This change: * fixes the error * removes the silent-skipping if check (the recompilation will fail in case it is wrongly set) * adds check at image verification whether dist/manifest.json is present. Fixes: apache#14991
potiuk
force-pushed
the
fix-removed-asset-recompilation
branch
from
4ab0abd to
0fcf08d
Compare
potiuk
added a commit
that referenced
this pull request
Mar 25, 2021
The change #14911 had a bug - when PYTHON_MINOR_MAJOR_VERSION was removed from the imge args, the replacement `python -m site` expression missed `/airflow/` suffix. Unfortunately it was not flagged as an error because the recompiling script silently skipped recompilation step in such case. This change: * fixes the error * removes the silent-skipping if check (the recompilation will fail in case it is wrongly set) * adds check at image verification whether dist/manifest.json is present. Fixes: #14991
ashb
pushed a commit
that referenced
this pull request
Apr 15, 2021
The change #14911 had a bug - when PYTHON_MINOR_MAJOR_VERSION was removed from the imge args, the replacement `python -m site` expression missed `/airflow/` suffix. Unfortunately it was not flagged as an error because the recompiling script silently skipped recompilation step in such case. This change: * fixes the error * removes the silent-skipping if check (the recompilation will fail in case it is wrongly set) * adds check at image verification whether dist/manifest.json is present. Fixes: #14991
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change #14911 had a bug - when PYTHON_MINOR_MAJOR_VERSION
was removed from the imge args, the replacement
python -m siteexpression missed
/airflow/suffix. Unfortunately it was notflagged as an error because the recompiling script silently
skipped recompilation step in such case.
This change:
fail in case it is wrongly set)
present.
Fixes: #14991
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.