Skip to content

Fix Sphinx Issues with Docstrings#14968

Merged
kaxil merged 8 commits into
apache:masterfrom
sunkickr:docstrings
Mar 26, 2021
Merged

Fix Sphinx Issues with Docstrings#14968
kaxil merged 8 commits into
apache:masterfrom
sunkickr:docstrings

Conversation

@sunkickr

Copy link
Copy Markdown
Contributor

This PR fix some typos and issues were the doctrings do not adhere to sphinx standards in the following modules:

  • AWSDataSyncOperator
  • S3KeySizeSensor
  • DatadogHook
  • DatadogSensor
  • ComputeEngineSSHHook
  • CloudDataCatalogLookupEntryOperator
  • GoogleDisplayVideo360UploadLineItemsOperator
  • GoogleDisplayVideo360CreateSDFDownloadTaskOperator
  • GoogleDisplayVideo360SDFtoGCSOperator
  • AzureBatchOperator
  • AzureCosmosDocumentSensor
  • SingularityOperator
  • SlackAPIOperator
  • DataprocCreateMapReduceJobOperator
  • DataprocCreateSparkJobOperator
  • DataprocCreatePysparkJobOperator

@boring-cyborg boring-cyborg Bot added area:providers provider:amazon AWS/Amazon - related issues provider:microsoft-azure Azure-related issues provider:google Google (including GCP) related issues labels Mar 23, 2021
@github-actions github-actions Bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 23, 2021
@github-actions

Copy link
Copy Markdown
Contributor

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@kaxil kaxil changed the title Fix Spinx Issues with Docstrings Fix Sphinx Issues with Docstrings Mar 24, 2021
@github-actions

Copy link
Copy Markdown
Contributor

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions

Copy link
Copy Markdown
Contributor

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions

Copy link
Copy Markdown
Contributor

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions

Copy link
Copy Markdown
Contributor

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions

Copy link
Copy Markdown
Contributor

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@sunkickr

sunkickr commented Mar 24, 2021

Copy link
Copy Markdown
Contributor Author

@kaxil is there anything that needs to be done to merge? Not sure why the tests are failing. Error message says ERROR: After October 2020 you may experience errors when installing or updating packages. This is because pip will change the way that it resolves dependency conflicts.

@kaxil

kaxil commented Mar 24, 2021

Copy link
Copy Markdown
Member

Looks like an un-related failure

  apache-beam 2.28.0 has requirement dill<0.3.2,>=0.3.1.1, but you have dill 0.3.3.

@github-actions

Copy link
Copy Markdown
Contributor

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@uranusjr

Copy link
Copy Markdown
Member

The same conflict seems to be failing CI on other PRs as well.

@kaxil

kaxil commented Mar 25, 2021

Copy link
Copy Markdown
Member

@potiuk Any ideas on why the Provider packages job is trying to rebuild image, I checked only jobs on 2.0.1 and old commits -- where it didn't

Example that worked: https://github.com/apache/airflow/runs/2124903826#step:6:87

Example that fails: https://github.com/apache/airflow/runs/2188111255#step:6:76

@potiuk

potiuk commented Mar 25, 2021

Copy link
Copy Markdown
Member

This is super strange. The root cause is that between one step and another looks like the yarn.lock and package.json are changed ! but nothing touches them really between the two (and it always worked fine)

In another PR we see the same:

https://github.com/apache/airflow/pull/14968/checks?check_run_id=2188403270#step:5:125

  Updated md5sum file /home/runner/actions-runner/_work/airflow/airflow/.build/master/3.6/CI/package.json.md5sum for /home/runner/actions-runner/_work/airflow/airflow/airflow/www/package.json.
  Updated md5sum file /home/runner/actions-runner/_work/airflow/airflow/.build/master/3.6/CI/yarn.lock.md5sum for /home/runner/actions-runner/_work/airflow/airflow/airflow/www/yarn.lock.

And in the next step (same runner, same job):
https://github.com/apache/airflow/pull/14968/checks?check_run_id=2188403270#step:6:86

  The md5sum changed for /home/runner/actions-runner/_work/airflow/airflow/airflow/www/package.json
  The md5sum changed for /home/runner/actions-runner/_work/airflow/airflow/airflow/www/yarn.lock

@sunkickr sunkickr requested a review from vikramkoka as a code owner March 26, 2021 14:27
@github-actions

Copy link
Copy Markdown
Contributor

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions

Copy link
Copy Markdown
Contributor

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@kaxil kaxil merged commit a7ca1b3 into apache:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:amazon AWS/Amazon - related issues provider:google Google (including GCP) related issues provider:microsoft-azure Azure-related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants