Skip to content

Fix import cycle in cluster policy examples #14973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaxil merged 2 commits into from
Mar 24, 2021
Merged

Fix import cycle in cluster policy examples #14973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3df9e2e
Fix import cycle in cluster policy examples
dstandish Mar 24, 2021
d49cc07
add note in docs
dstandish Mar 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/apache-airflow/concepts.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1350,6 +1350,12 @@ Here is what it may look like:
:start-after: [START example_dag_cluster_policy]
:end-before: [END example_dag_cluster_policy]


.. note::

To avoid import cycles, if using ``DAG`` in type annotations in your cluster policy, be sure to import from ``airflow.models`` and not from ``airflow``.


Task level cluster policy
-----------------------------
For example, this function could apply a specific queue property when
Expand Down
3 changes: 1 addition & 2 deletions tests/cluster_policies/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,9 @@
from datetime import timedelta
from typing import Callable, List

from airflow import DAG
from airflow.configuration import conf
from airflow.exceptions import AirflowClusterPolicyViolation
from airflow.models import TaskInstance
from airflow.models import DAG, TaskInstance
from airflow.models.baseoperator import BaseOperator


Expand Down