Refactor id and hashing

[mickvandijke]

No description provided.

[greptile-apps]

Greptile Summary

This PR performs two related refactors: (1) a full migration of the content-addressing hash algorithm from SHA256 (sha2 crate) to BLAKE3 (blake3 crate) across storage, client, protocol, upgrade, and test layers, and (2) a type-safety cleanup in DevnetNode and TestNetwork — renaming node_id: String to label: String, upgrading peer_id from a hex String to the typed PeerId, and removing several unnecessary PeerId copies when passing references to send_and_await_chunk_response.

Key changes:

• compute_address in src/client/data_types.rs now uses blake3::hash instead of sha2::Sha256; all known-hash test vectors are updated accordingly
• StagedRollout in src/upgrade/rollout.rs migrates to blake3; note that all existing nodes will receive new (but still deterministic) upgrade-delay slots after this change
• TestNetwork generates a fresh NodeIdentity per node and assigns it to core_config.node_identity, enabling auto identity-announce on connect

Important: The SHA256 → BLAKE3 switch is a breaking change for any persistent data. Chunk addresses stored under the old scheme are SHA256-derived and will not be found by the new BLAKE3-based lookups. There is no migration path included in this PR — all persisted storage will need to be wiped and re-ingested after deployment.

Confidence Score: 5/5

• Safe to merge for a pre-production/devnet environment; requires a clean wipe of all stored data before deploying to any environment that previously ran the SHA256-based build.
• The hash migration is consistent and complete — every call site, test vector, and doc comment has been updated. The type-safety refactor is clean. No functional issues identified. The inherent breaking change to stored content addresses is a known architectural requirement of the hash algorithm migration, not a code defect in the new implementation.
• No files require special attention

_{Last reviewed commit: c0e3c77}

[Copilot]

Pull request overview

Refactors peer identity handling and switches content-addressing/hashing from SHA-256 to BLAKE3 across the node, storage, client, and E2E test utilities.

Changes:

• Replace SHA-256 with BLAKE3 for XorName/content addressing and update related docs/tests/expected vectors.
• Simplify PeerId usage by passing references directly (remove redundant copies / fully-qualified types).
• Ensure devnet/testnet nodes have a node_identity configured for signing/identity announce behavior.

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/e2e/testnet.rs	Uses PeerId aliasing and adjusts remote chunk ops; adds node identity setup (currently duplicated/overwritten).
tests/e2e/live_testnet.rs	Updates content-addressing doc comment to BLAKE3.
tests/e2e/integration_tests.rs	Adjusts peer selection and updates address/hash expectation comments.
tests/e2e/data_types/scratchpad.rs	Switches scratchpad address derivation to BLAKE3.
tests/e2e/data_types/pointer.rs	Switches pointer address derivation to BLAKE3.
tests/e2e/data_types/graph_entry.rs	Switches graph entry address derivation to BLAKE3.
tests/e2e/data_types/chunk.rs	Updates chunk addressing docs and known-hash test vectors to BLAKE3.
src/upgrade/rollout.rs	Uses BLAKE3 for deterministic rollout hashing.
src/storage/lmdb.rs	Updates docs/tests to reflect BLAKE3-derived addresses.
src/storage/handler.rs	Updates address verification comment to BLAKE3.
src/node.rs	Minor comment punctuation tweak.
src/devnet.rs	Refactors devnet node labeling/peer id typing and loads identity for message signing.
src/client/quantum.rs	Updates docs to state BLAKE3 addressing.
src/client/mod.rs	Updates module docs to state BLAKE3 addressing.
src/client/data_types.rs	Implements compute_address using BLAKE3.
src/client/chunk_protocol.rs	Removes redundant PeerId copy; compares source against *target_peer.
src/ant_protocol/chunk.rs	Updates docs to state BLAKE3 addressing.
Cargo.toml	Replaces sha2 dependency with blake3.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.