fix: configure max message size for devnet protocol#15
Merged
dirvine merged 1 commit intoWithAutonomi:mainfrom Mar 1, 2026
Merged
Conversation
Set `core_config.max_message_size` to align with the protocol's max wire message size. Update related configs and ignore `devnet-manifest.json` in `.gitignore`.
There was a problem hiding this comment.
Pull request overview
This PR aligns devnet and saorsa-client transport configuration with the ANT protocol’s expected maximum wire message size, and avoids accidentally committing a generated devnet manifest.
Changes:
- Set
core_config.max_message_sizetoMAX_WIRE_MESSAGE_SIZEfor devnet nodes. - Set
core_config.max_message_sizetoMAX_WIRE_MESSAGE_SIZEforsaorsa-client. - Add
devnet-manifest.jsonto.gitignore.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/devnet.rs |
Configures devnet P2P nodes to use the protocol’s max wire message size. |
src/bin/saorsa-client/main.rs |
Configures the client’s P2P node to use the protocol’s max wire message size. |
.gitignore |
Prevents generated devnet-manifest.json from being committed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Greptile SummaryConfigures
Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| .gitignore | Adds devnet-manifest.json to gitignore - correct since this is a generated local development file |
| src/bin/saorsa-client/main.rs | Configures max_message_size to match protocol's 5MB wire message limit - necessary for client to handle max-size chunks |
| src/devnet.rs | Configures max_message_size for devnet P2P nodes to match protocol expectations - ensures compatibility with client and other nodes |
Last reviewed commit: 05be836
dirvine
approved these changes
Mar 1, 2026
Collaborator
dirvine
left a comment
dirvine
left a comment
There was a problem hiding this comment.
Looks great — thanks Mick for the clean fix and for aligning client/devnet message-size limits with protocol expectations.
mickvandijke
added a commit
that referenced
this pull request
Apr 1, 2026
Complete the Section 18 test matrix with the remaining scenarios: - #3: Fresh replication stores chunk + updates PaidForList on remote nodes - #9: Fetch retry rotates to alternate source - #10: Fetch retry exhaustion with single source - #11: Repeated ApplicationFailure events decrease peer trust score - #12: Bootstrap node discovers keys stored on multiple peers - #14: Hint construction covers all locally stored keys - #15: Data and PaidForList survive node shutdown (partition) - #17: Neighbor sync request returns valid response (admission test) - #21: Paid-list majority confirmed from multiple peers via verification - #24: PaidNotify propagates paid-list entries after fresh replication - #25: Paid-list convergence verified via majority peer queries - #44: PaidForList persists across restart (cold-start recovery) - #45: PaidForList lost in fresh directory (unrecoverable scenario) All 56 Section 18 scenarios now have test coverage. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mickvandijke
added a commit
that referenced
this pull request
Apr 1, 2026
- #3: Add proper unit test in scheduling.rs exercising full pipeline (PendingVerify → QueuedForFetch → Fetching → Stored); rename mislabeled e2e test to scenario_1_and_24 - #12: Rewrite e2e test to send verification requests to 4 holders and assert quorum-level presence + paid confirmations - #13: Rename mislabeled bootstrap drain test in types.rs; add proper unit test in paid_list.rs covering range shrink, hysteresis retention, and new key acceptance - #14: Rewrite e2e test to send NeighborSyncRequest and assert response hints cover all locally stored keys - #15: Rewrite e2e test to store on 2 nodes, partition one, then verify paid-list authorization confirmable via verification request - #17: Rewrite e2e test to store data on receiver, send sync, and assert outbound replica hints returned (proving bidirectional exchange) - #55: Replace weak enum-distinctness check with full audit failure flow: compute digests, identify mismatches, filter by responsibility, verify empty confirmed failure set produces no evidence Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mickvandijke
added a commit
that referenced
this pull request
Apr 1, 2026
Complete the Section 18 test matrix with the remaining scenarios: - #3: Fresh replication stores chunk + updates PaidForList on remote nodes - #9: Fetch retry rotates to alternate source - #10: Fetch retry exhaustion with single source - #11: Repeated ApplicationFailure events decrease peer trust score - #12: Bootstrap node discovers keys stored on multiple peers - #14: Hint construction covers all locally stored keys - #15: Data and PaidForList survive node shutdown (partition) - #17: Neighbor sync request returns valid response (admission test) - #21: Paid-list majority confirmed from multiple peers via verification - #24: PaidNotify propagates paid-list entries after fresh replication - #25: Paid-list convergence verified via majority peer queries - #44: PaidForList persists across restart (cold-start recovery) - #45: PaidForList lost in fresh directory (unrecoverable scenario) All 56 Section 18 scenarios now have test coverage. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mickvandijke
added a commit
that referenced
this pull request
Apr 1, 2026
- #3: Add proper unit test in scheduling.rs exercising full pipeline (PendingVerify → QueuedForFetch → Fetching → Stored); rename mislabeled e2e test to scenario_1_and_24 - #12: Rewrite e2e test to send verification requests to 4 holders and assert quorum-level presence + paid confirmations - #13: Rename mislabeled bootstrap drain test in types.rs; add proper unit test in paid_list.rs covering range shrink, hysteresis retention, and new key acceptance - #14: Rewrite e2e test to send NeighborSyncRequest and assert response hints cover all locally stored keys - #15: Rewrite e2e test to store on 2 nodes, partition one, then verify paid-list authorization confirmable via verification request - #17: Rewrite e2e test to store data on receiver, send sync, and assert outbound replica hints returned (proving bidirectional exchange) - #55: Replace weak enum-distinctness check with full audit failure flow: compute digests, identify mismatches, filter by responsibility, verify empty confirmed failure set produces no evidence Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_message_sizetoMAX_WIRE_MESSAGE_SIZEon the saorsa-client and devnet P2P nodes so they match the protocol's expected message size limitdevnet-manifest.jsonto.gitignoreTest plan
🤖 Generated with Claude Code