Update Soot and choose an analyzable JRE #373 #890
Merged
sergeypospelov merged 3 commits intomainfrom Sep 14, 2022
Merged
Conversation
698ad47 to
dc8da58
Compare
SBOne-Kenobi
approved these changes
Sep 13, 2022
Collaborator
SBOne-Kenobi
left a comment
There was a problem hiding this comment.
LGTM, waiting for tests ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
jdkInfofield in theTestCaseGeneratorfor providing an analyzable JDK.Also found an internal Soot bug which affects us too: soot-oss/soot#1360.
Please note, that Soot slightly changed public API:
stmt.rightBox.valuetostmt.rightOpFixes #373
Type of Change
How Has This Been Tested?
Automated Testing
Added new tests, but they are disabled right now. Other unit-tests successfully pass.
Manual Scenario
To reproduce section from #373 passes.
Checklist (remove irrelevant options):