Conversation
Contributor
|
@jwildfire Makes sense to me. As we develop more extensions I'll ask you what you think best practices should be going forward. Unrelated, I am back from vacation so I should be good to starting taking some more PR reviews in the future! |
Contributor
Author
|
Error is in this line. My best guess is that there is a syntax issue with dplyr. Code to reproduce below. Will dig in more later to debug: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
@elimillera - The refactor in SafetyGraphics/safetyGraphics#594 makes the rendering process a bit more rigid which broke the the RTF renderer. This converts it to a simple shiny module instead of its own custom type. This might not be the best long term answer, but should be good enough for the v2 release.
Fixes #70
Test Notes
@xni7 - Please review with SafetyGraphics/safetyGraphics#594