Skip to content

convert RTF demographics table to simple module.#72

Merged
jwildfire merged 1 commit into
devfrom
rtf-mod
Aug 4, 2021
Merged

convert RTF demographics table to simple module.#72
jwildfire merged 1 commit into
devfrom
rtf-mod

Conversation

@jwildfire

Copy link
Copy Markdown
Contributor

Overview

@elimillera - The refactor in SafetyGraphics/safetyGraphics#594 makes the rendering process a bit more rigid which broke the the RTF renderer. This converts it to a simple shiny module instead of its own custom type. This might not be the best long term answer, but should be good enough for the v2 release.

Fixes #70

Test Notes

@xni7 - Please review with SafetyGraphics/safetyGraphics#594

@xni7 xni7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great now!

@elimillera

Copy link
Copy Markdown
Contributor

@jwildfire Makes sense to me. As we develop more extensions I'll ask you what you think best practices should be going forward.

Unrelated, I am back from vacation so I should be good to starting taking some more PR reviews in the future!

@jwildfire

jwildfire commented Oct 1, 2021

Copy link
Copy Markdown
Contributor Author

Error is in this line.

My best guess is that there is a syntax issue with dplyr. Code to reproduce below. Will dig in more later to debug:

library(yaml)
library(safetyCharts)

#Load Data
data<-safetyData::adam_adsl

#Load mapping
mapping_yaml<-"id_col: USUBJID
treatment_col: ARM
treatment_values:
  group1: ''
  group2: ''
sex_col: SEX
race_col: RACE
age_col: AGE
"
mapping <- read_yaml(text=mapping_yaml)
settings<-mapping

tplyr_tab <- Tplyr::tplyr_table(data, !!sym(settings$treatment_col)) %>%
    Tplyr::add_total_group() %>%
    Tplyr::add_layer(
        Tplyr::group_count(!!sym(settings$race_col), by = "Race")
    ) %>%
    Tplyr::add_layer(
        Tplyr::group_desc(!!sym(settings$age_col), by = "Age (Years)")
    )

treatments<- unique(data[,settings$treatment_col])
treatment_vars <- paste0("var1_",treatments)
treatment_labels <- paste0(treatments, "\\line(N=**",treatments,"**)|", collapse=" ")
header <- paste0(" | | ",treatment_labels," Total\\line(N=**Total**)")
tab <- tplyr_tab %>%
    Tplyr::build() %>%
    arrange(.data$ord_layer_index, .data$ord_layer_1, .data$ord_layer_2) %>% 
    select(starts_with("row_label"), treatment_vars, .data$var1_Total) 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert rtf demographics table to module

3 participants