[autobackport: sssd-2-10] tests: reorganize infopipe tests by interface#8461
Draft
sssd-bot wants to merge 1 commit intoSSSD:sssd-2-10from
Draft
[autobackport: sssd-2-10] tests: reorganize infopipe tests by interface#8461sssd-bot wants to merge 1 commit intoSSSD:sssd-2-10from
sssd-bot wants to merge 1 commit intoSSSD:sssd-2-10from
Conversation
Group the infopipe tests into logical sections based on the D-Bus interface they exercise: - Infopipe (root object) - Domains - Users - Groups - Mixed/Combined interfaces This is a pure reorganization with no logic changes to improve test maintainability and readability. Reviewed-by: Jakub Vávra <jvavra@redhat.com> Reviewed-by: Shridhar Gadekar <sgadekar@redhat.com> (cherry picked from commit 1571946)
There was a problem hiding this comment.
Code Review
The code changes in this pull request reorganize the infopipe tests by interface. The changes include tests for pinging the infopipe, listing components, finding a monitor, finding a user by ID, and updating user groups. There is a merge conflict in the file that needs to be resolved, keeping the test_infopipe__find_user_by_id function.
Comment on lines
+354
to
+361
| <<<<<<< HEAD | ||
| @pytest.mark.ticket(bz=1667252) | ||
| @pytest.mark.topology(KnownTopologyGroup.AnyProvider) | ||
| def test_infopipe__lookup_user_with_extra_attributes(client: Client, provider: GenericProvider): | ||
| ======= | ||
| @pytest.mark.topology(KnownTopology.LDAP) | ||
| def test_infopipe__find_user_by_id(client: Client, provider: GenericProvider): | ||
| >>>>>>> 157194618 (tests: reorganize infopipe tests by interface) |
There was a problem hiding this comment.
This file contains merge conflict markers which make it syntactically incorrect. Please resolve the conflict. Based on the PR's goal of reorganizing tests, it seems test_infopipe__find_user_by_id should be kept here.
@pytest.mark.topology(KnownTopology.LDAP)
def test_infopipe__find_user_by_id(client: Client, provider: GenericProvider):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of PR#8451 tests: reorganize infopipe tests by interface to branch sssd-2-10, created by @aborah-sudo.
Caution
@aborah-sudo The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with
CONFLICT!.You can push changes to this pull request
Original commits
1571946 - tests: reorganize infopipe tests by interface
Backported commits
Conflicting Files Information (check for deleted and re-added files)
Original Pull Request Body
Group the infopipe tests into logical sections based on the D-Bus interface they exercise:
This is a pure reorganization with no logic changes to improve test maintainability and readability.