tests: reorganize infopipe tests by interface#8451
Merged
alexey-tikhonov merged 1 commit intoSSSD:masterfrom Feb 18, 2026
Merged
tests: reorganize infopipe tests by interface#8451alexey-tikhonov merged 1 commit intoSSSD:masterfrom
alexey-tikhonov merged 1 commit intoSSSD:masterfrom
Conversation
aborah-sudo
added
Waiting for review
Tests
Trivial
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively reorganizes the infopipe tests into logical sections based on the D-Bus interface, which significantly improves test maintainability and readability as intended. The addition of new tests is also a great enhancement. I have one suggestion to improve the robustness of one of the new tests.
aborah-sudo
changed the title
alexey-tikhonov
removed
Accepted
Ready to push
Trivial
aborah-sudo
force-pushed
the
rearrange
branch
from
bc54100 to
6d9ca41
Compare
aborah-sudo
requested review from
ikerexxe
and removed request for
shridhargadekar
aborah-sudo
requested review from
shridhargadekar
and removed request for
ikerexxe
shridhargadekar
requested changes
Feb 17, 2026
shridhargadekar
requested changes
Feb 17, 2026
aborah-sudo
force-pushed
the
rearrange
branch
from
6d9ca41 to
7033792
Compare
aborah-sudo
force-pushed
the
rearrange
branch
from
a982cb7 to
1e17cbe
Compare
alexey-tikhonov
added
Accepted
and removed
backport-to-sssd-2-9-4
Group the infopipe tests into logical sections based on the D-Bus interface they exercise: - Infopipe (root object) - Domains - Users - Groups - Mixed/Combined interfaces This is a pure reorganization with no logic changes to improve test maintainability and readability. Reviewed-by: Jakub Vávra <jvavra@redhat.com> Reviewed-by: Shridhar Gadekar <sgadekar@redhat.com>
Contributor
This was referenced Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group the infopipe tests into logical sections based on the D-Bus interface they exercise:
This is a pure reorganization with no logic changes to improve test maintainability and readability.