Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7263 +/- ##
=======================================
Coverage 98.80% 98.80%
=======================================
Files 81 81
Lines 15250 15250
=======================================
Hits 15067 15067
Misses 183 183 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tdhock
reviewed
Aug 25, 2025
NEWS.md
Outdated
|
|
||
| 1. `data.table(x=1, <expr>)`, where `<expr>` is an expression resulting in a 1-column matrix without column names, will eventually have names `x` and `V2`, not `x` and `V1`, consistent with `data.table(x=1, <expr>)` where `<expr>` results in an atomic vector, for example `data.table(x=1, cbind(1))` and `data.table(x=1, 1)` will both have columns named `x` and `V2`. In this release, the matrix case continues to be named `V1`, but the new behavior can be activated by setting `options(datatable.old.matrix.autoname)` to `FALSE`. See point 5 under Bug Fixes for more context; this change will provide more internal consistency as well as more consistency with `data.frame()`. | ||
|
|
||
| 2. `dcast()` now errors when `fun.aggregate` returns length != 1, regardless of `fill` ([#6629](https://github.com/Rdatatable/data.table/issues/6629),[#6032](https://github.com/Rdatatable/data.table/issues/6032)). Previously, when `fill` was not `NULL`, `dcast` warned and returned an undefined result. Updated code to use a scalar-returning aggregator instead of identity or functions that return vectors. |
Member
There was a problem hiding this comment.
Suggested change
| 2. `dcast()` now errors when `fun.aggregate` returns length != 1, regardless of `fill` ([#6629](https://github.com/Rdatatable/data.table/issues/6629),[#6032](https://github.com/Rdatatable/data.table/issues/6032)). Previously, when `fill` was not `NULL`, `dcast` warned and returned an undefined result. Updated code to use a scalar-returning aggregator instead of identity or functions that return vectors. | |
| 2. `dcast()` now errors when `fun.aggregate` returns length != 1 (consistent with documentation), regardless of `fill` ([#6629](https://github.com/Rdatatable/data.table/issues/6629),[#6032](https://github.com/Rdatatable/data.table/issues/6032)). Previously, when `fill` was not `NULL`, `dcast` warned and returned an undefined result. This change has been planned since 1.16.0 (25 Aug 2024). |
also please move to section
### BREAKING CHANGE
Updated breaking changes and new features in NEWS.md.
tdhock
reviewed
Aug 25, 2025
Co-authored-by: Toby Dylan Hocking <tdhock5@gmail.com>
tdhock
reviewed
Aug 25, 2025
Co-authored-by: Toby Dylan Hocking <tdhock5@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added news section breaking change in PR #7260