Error on non scalar aggregates regardless of fill#7260
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7260 +/- ##
=========================================
Coverage ? 98.80%
=========================================
Files ? 81
Lines ? 15250
Branches ? 0
=========================================
Hits ? 15067
Misses ? 183
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Generated via commit d000179 Download link for the artifact containing the test results: ↓ atime-results.zip
|
tdhock
approved these changes
Aug 23, 2025
Member
|
sorry I merged too quickly. please submit another pr with a news item |
Merged
Contributor
Author
|
Sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

closes #6629
In dcast, fun.aggregate must return length 1. Previously, with fill != NULL, dcast warned but still produced an undefined result #6032. Plan is to turn that into an error
So in this PR
Dcast breaking change(fcast.R)
@tdhock @joshhwuu @Anirban166 please review.