Skip to content

Error on non scalar aggregates regardless of fill#7260

Merged
tdhock merged 1 commit intomasterfrom
6629_issue
Aug 23, 2025
Merged

Error on non scalar aggregates regardless of fill#7260
tdhock merged 1 commit intomasterfrom
6629_issue

Conversation

@Mukulyadav2004
Copy link
Contributor

closes #6629

In dcast, fun.aggregate must return length 1. Previously, with fill != NULL, dcast warned but still produced an undefined result #6032. Plan is to turn that into an error

So in this PR
Dcast breaking change(fcast.R)

@tdhock @joshhwuu @Anirban166 please review.

@Mukulyadav2004 Mukulyadav2004 requested a review from tdhock as a code owner August 22, 2025 23:49
@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@c27ec26). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #7260   +/-   ##
=========================================
  Coverage          ?   98.80%           
=========================================
  Files             ?       81           
  Lines             ?    15250           
  Branches          ?        0           
=========================================
  Hits              ?    15067           
  Misses            ?      183           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

  • HEAD=6629_issue slower P<0.001 for DT[by,verbose=TRUE] improved in #6296
    Comparison Plot

Generated via commit d000179

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 52 seconds
Installing different package versions 10 minutes and 4 seconds
Running and plotting the test cases 2 minutes and 37 seconds

@tdhock tdhock merged commit 55bbc3d into master Aug 23, 2025
12 checks passed
@tdhock
Copy link
Member

tdhock commented Aug 23, 2025

sorry I merged too quickly. please submit another pr with a news item

@Mukulyadav2004
Copy link
Contributor Author

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

move from warning to breaking change in melt/dcast

2 participants