You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
on my local windows machine, all tests pass.
this could be a "breaking change" since patterns now outputs character instead of integer.
But when patterns() is used in the context of melt() or .SDcols, it gives the same result before/after this PR. (so no breakage for the typical use case)
And I don't think people should be using patterns() otherwise (although it is exported).
Thanks @tdhock. I love this change. For me, and I believe most DT users, the primary use of patterns is to extract columns in melt and .SDcols, so no break changes in this aspect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6498
Before this PR:
above result is unexpected since variable=x2 which is not present in cols.
After this PR:
above result is better since y2 variable is present in cols.
this provides functionality similar to #6077