Merged
Conversation
Member
Author
|
ok tests are passing and I added a NEWS item, so I believe this one is ready to merge. |
This was referenced Sep 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5063 in which some users wanted to provide the cols arg to measure, which may be useful/convenient instead of using pattern arg.
This is an alternative to #5115 which would make using the cols arg an error. Moving forward with that other PR would be complicated since there is quite a bit of code which is using the cols arg with patterns, thanks @MichaelChirico for investigating.
So this PR may be considered if we want to add support for cols arg (seems like users want it in #5063 at least).