Address admin and profile UI TODOs#431
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThis PR seeds a developer user and assigns emulators, adds replacement-aware deletion for performance scales with count-aware UI gating, replaces loading spinners with skeleton UIs in social connection lists, refactors profile component typings to UseQueryResult, and removes several inline comments. ChangesDeveloper Seed Setup & Emulator Assignment
Performance Scale Replacement Feature
Social Connection List Skeleton Loading
Profile Component Typing and Query Management
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/server/repositories/performance-scales.repository.ts`:
- Around line 109-111: The duplicate-ID validation currently calls
AppError.badRequest(...) but doesn't throw it, so the check is ineffective;
update the conditional handling where replacementId === id to throw the error
(e.g., throw AppError.badRequest('Replacement performance scale must be
different from the deleted scale')) so the request fails as intended and
execution stops in the method that contains the replacementId/id check.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: fc48f83a-ae8d-43ef-8343-70bc9496b80d
📒 Files selected for processing (15)
prisma/seed.tsprisma/seeders/usersSeeder.tssrc/app/admin/performance/components/ReplacementSelectionModal.tsxsrc/app/admin/performance/page.tsxsrc/app/admin/performance/types.tssrc/app/admin/users/components/UserBadgeModal.tsxsrc/app/profile/components/DeviceAndSocPreferences.tsxsrc/app/profile/components/connections/BlockedList.tsxsrc/app/profile/components/connections/FollowersList.tsxsrc/app/profile/components/connections/FriendsList.tsxsrc/app/profile/components/connections/SocialConnectionList.tsxsrc/schemas/performanceScale.tssrc/server/api/routers/performanceScales.tssrc/server/repositories/performance-scales.repository.tssrc/server/utils/emulator-config/eden/eden.defaults.ts
💤 Files with no reviewable changes (2)
- src/app/admin/users/components/UserBadgeModal.tsx
- src/server/utils/emulator-config/eden/eden.defaults.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses several small TODOs tracked in #411:
UseQueryResultPart of #411
Type of change
How Has This Been Tested?
Ran:
git diff --check./node_modules/.bin/eslint prisma/seed.ts prisma/seeders/usersSeeder.ts src/app/admin/performance/components/ReplacementSelectionModal.tsx src/app/admin/performance/page.tsx src/app/admin/performance/types.ts src/app/admin/users/components/UserBadgeModal.tsx src/app/profile/components/DeviceAndSocPreferences.tsx src/app/profile/components/connections/SocialConnectionList.tsx src/schemas/performanceScale.ts src/server/api/routers/performanceScales.ts src/server/repositories/performance-scales.repository.ts src/server/utils/emulator-config/eden/eden.defaults.ts./node_modules/.bin/prettier --check prisma/seed.ts prisma/seeders/usersSeeder.ts src/app/admin/performance/components/ReplacementSelectionModal.tsx src/app/admin/performance/page.tsx src/app/admin/performance/types.ts src/app/admin/users/components/UserBadgeModal.tsx src/app/profile/components/DeviceAndSocPreferences.tsx src/app/profile/components/connections/SocialConnectionList.tsx src/schemas/performanceScale.ts src/server/api/routers/performanceScales.ts src/server/repositories/performance-scales.repository.ts src/server/utils/emulator-config/eden/eden.defaults.tsDATABASE_URL=postgresql://postgres:postgres@localhost:5432/emuready ./node_modules/.bin/prisma validateAttempted:
pnpm types(blocked before TypeScript because pnpm tried to purge the symlinked worktreenode_moduleswithout a TTY)./node_modules/.bin/tsc --noEmit --pretty falseafter plain Prisma client generation (blocked by existing missing TypedSQL@orm/sqloutput andSegaSaturnIcon.pngmodule resolution outside this change)./node_modules/.bin/prisma generate --sql(blocked because TypedSQL requires a reachable local database)Screenshots (if applicable)
N/A
Checklist
Notes for reviewers
The trust-logs
AdminStatsDisplayitem from #411 was handled in #426. The mobile API-key enforcement TODO is intentionally left for a separate decision because it changes public mobile API access behavior.Summary by CodeRabbit
New Features
UI/UX Improvements
Bug Fixes