Standardize admin page layouts#426
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
WalkthroughFour admin pages (brands, cpus, socs, and trust-logs) are refactored to use the shared ChangesAdmin Page Layout Standardization
🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/app/admin/cpus/page.tsx`:
- Around line 141-143: Update the user-facing description string used alongside
title="CPUs" (the metadata/props block that currently reads description="Manage
all CPU models for PC compatibility listings") to use the approved terminology;
replace that value with "Manage all CPU models for the PC Compatibility Report"
so the UI uses "PC Compatibility Report" instead of "listings". Ensure the
change is made where the description prop/string is defined (adjacent to
title="CPUs" and headerActions).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 30b034b7-8df8-402e-91ea-90b7c68ff918
📒 Files selected for processing (4)
src/app/admin/brands/page.tsxsrc/app/admin/cpus/page.tsxsrc/app/admin/socs/page.tsxsrc/app/admin/trust-logs/page.tsx
Description
Updates the remaining admin pages called out in the issue to use the shared
AdminPageLayoutwrapper for their title, description, and header actions.Also aligns Trust Logs with shared admin primitives by using
AdminErrorStatefor full-page query failures andAdminStatsDisplayfor the stats summary. This removes the customTrustStatsOverviewcomponent and its dynamic import, while preserving the same displayed metrics.Fixes #376
Follow-up for #411
Type of change
How Has This Been Tested?
Ran:
git diff --check./node_modules/.bin/eslint src/app/admin/brands/page.tsx src/app/admin/cpus/page.tsx src/app/admin/socs/page.tsx src/app/admin/trust-logs/page.tsx./node_modules/.bin/prettier --check src/app/admin/brands/page.tsx src/app/admin/cpus/page.tsx src/app/admin/socs/page.tsx src/app/admin/trust-logs/page.tsx./node_modules/.bin/eslint src/app/admin/cpus/page.tsx./node_modules/.bin/prettier --check src/app/admin/cpus/page.tsx./node_modules/.bin/eslint src/app/admin/trust-logs/page.tsx src/lib/dynamic-imports.tsx src/components/admin/AdminStatsDisplay.tsx./node_modules/.bin/prettier --check src/app/admin/trust-logs/page.tsx src/lib/dynamic-imports.tsx src/components/admin/AdminStatsDisplay.tsxAttempted:
./node_modules/.bin/tsc --noEmit --pretty false(blocked by existing missing generated@orm/@orm/clientmodules and unrelated type errors)Screenshots (if applicable)
N/A
Checklist
Notes for reviewers
This keeps the existing page table behavior intact while standardizing the page shell, error state, and stats display.
Summary by CodeRabbit
Refactor
Bug Fixes
New Features