Skip to content

Fix message copy action in Command Center #3854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmarticus wants to merge 1 commit into from
Closed

Fix message copy action in Command Center #3854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions packages/ui/src/features/sessions/components/session-update/AgentMessage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import { Theme } from "@radix-ui/themes";
import { render, screen } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { describe, expect, it, vi } from "vitest";
import { AgentMessage } from "./AgentMessage";

describe("AgentMessage", () => {
it("keeps the copy action inside the message rail", async () => {
const writeText = vi.fn().mockResolvedValue(undefined);
Object.assign(navigator, { clipboard: { writeText } });

render(
<Theme>
<AgentMessage content="Assistant response" />
</Theme>,
);

const copyButton = screen.getByLabelText("Copy message");
expect(copyButton.parentElement).toHaveClass("right-1");
expect(copyButton.parentElement).not.toHaveClass("left-full");

await userEvent.click(copyButton);
expect(writeText).toHaveBeenCalledWith("Assistant response");
});
});
4 changes: 2 additions & 2 deletions packages/ui/src/features/sessions/components/session-update/AgentMessage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export const AgentMessage = memo(function AgentMessage({
}, [content]);

return (
<Box className="group/msg relative pl-3 text-[13px] [&>*:last-child]:mb-0 [&_p]:leading-[1.9]">
<Box className="group/msg relative pr-9 pl-3 text-[13px] [&>*:last-child]:mb-0 [&_p]:leading-[1.9]">
{isStreaming ? (
<StreamingMarkdown
content={smoothed}
Expand All @@ -82,7 +82,7 @@ export const AgentMessage = memo(function AgentMessage({
componentsOverride={agentComponents}
/>
)}
<Box className="absolute top-1 left-full ml-2 opacity-0 transition-opacity group-hover/msg:opacity-100">
<Box className="absolute top-1 right-1 opacity-0 transition-opacity group-hover/msg:opacity-100">
<Tooltip content={copied ? "Copied!" : "Copy message"}>
<IconButton
size="1"
Expand Down
Loading