Fix message copy action in Command Center - #3854
Closed
dmarticus wants to merge 1 commit into
Closed
Conversation
Generated-By: PostHog Code Task-Id: 11e8a530-136e-44e6-af1f-3eb6a0ee49c0
|
🚫 This pull request was removed from the merge queue because it was closed by @dmarticus. See more details here. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
Author
|
ah, looks like someone caught this. closing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The assistant-message copy action is positioned outside the message bounds and gets clipped in compact Command Center conversations.
Why: People should have the same copy affordance whether they view a task standalone or in the Command Center.
Changes
Keep the hover copy action inside the assistant message rail and reserve enough space to prevent it from covering message content. Add a regression test for the placement and clipboard behavior.
How did you test this?
pnpm --filter @posthog/shared buildpnpm --filter @posthog/ui exec vitest run src/features/sessions/components/session-update/AgentMessage.test.tsxpnpm exec biome check packages/ui/src/features/sessions/components/session-update/AgentMessage.tsx packages/ui/src/features/sessions/components/session-update/AgentMessage.test.tsxAutomatic notifications
Created with PostHog Code