[9.0][website_blog_excerpt_img] Migrate, LGPL. - #298
Merged
Conversation
rafaelbn
requested changes
Dec 21, 2016
rafaelbn
left a comment
rafaelbn
left a comment
Member
There was a problem hiding this comment.
- Go to Runbot
- Go to blog without login
- 500: Internal Server Error
Please check
yajo
force-pushed
the
9.0-website_blog_excerpt_img-mig
branch
2 times, most recently
from
December 22, 2016 11:08
4bab9b2 to
120a927
Compare
Member
Author
|
Rebased, squashed, added tests, and fixed problem. |
yajo
force-pushed
the
9.0-website_blog_excerpt_img-mig
branch
2 times, most recently
from
December 23, 2016 12:37
694783f to
7272be0
Compare
Member
Author
|
Travis seems affected too by OCA/server-tools#666 |
yajo
force-pushed
the
9.0-website_blog_excerpt_img-mig
branch
3 times, most recently
from
December 28, 2016 08:13
3cc4a29 to
69b44f9
Compare
yajo
force-pushed
the
9.0-website_blog_excerpt_img-mig
branch
5 times, most recently
from
December 28, 2016 13:09
5a194c5 to
94fe8ff
Compare
Member
|
Can you please rebase? |
Add an excerpt and an image taken from the post to the blog summary page. To make this work, these open PR need to be merged: - OCA/server-tools#354 - OCA/server-tools#355
…//localhost/blog/our-news-1/post/blog-post-title-3?enable_editor=1`, not empty, so fixing here to avoid failure loading empty covers.
Fix bug in generated images, add convenient classes. The output of some images was a generator instead of an URL. I add excerpt-txt and excerpt-img classes for make life easier for themes. Add basic styling. All images now have the same height, and excerpts are 80 words long, which mostly matches the image height. Update for upstream module rename.
Relicensed, migrated, new tests.
yajo
force-pushed
the
9.0-website_blog_excerpt_img-mig
branch
from
January 4, 2017 12:35
94fe8ff to
489dadf
Compare
pedrobaeza
approved these changes
Feb 3, 2017
Member
|
@rafaelbn please re-review this |
rafaelbn
approved these changes
Oct 12, 2017
cristinamartinrod
pushed a commit
to Tecnativa/website
that referenced
this pull request
Feb 15, 2019
* [8.0][website_blog_excerpt_img] New layout for blog. Add an excerpt and an image taken from the post to the blog summary page. To make this work, these open PR need to be merged: - OCA/server-tools#354 - OCA/server-tools#355 * Default value for `background_image` is usually something like `http://localhost/blog/our-news-1/post/blog-post-title-3?enable_editor=1`, not empty, so fixing here to avoid failure loading empty covers. * Simpler logic and better layout in phones. Fix bug in generated images, add convenient classes. The output of some images was a generator instead of an URL. I add excerpt-txt and excerpt-img classes for make life easier for themes. Add basic styling. All images now have the same height, and excerpts are 80 words long, which mostly matches the image height. Update for upstream module rename. * OCA Transbot updated translations from Transifex * [9.0][website_blog_excerpt_img] Migrate, LGPL. Relicensed, migrated, new tests.
yajo
added a commit
to Tecnativa/website
that referenced
this pull request
Apr 23, 2019
* [8.0][website_blog_excerpt_img] New layout for blog. Add an excerpt and an image taken from the post to the blog summary page. To make this work, these open PR need to be merged: - OCA/server-tools#354 - OCA/server-tools#355 * Default value for `background_image` is usually something like `http://localhost/blog/our-news-1/post/blog-post-title-3?enable_editor=1`, not empty, so fixing here to avoid failure loading empty covers. * Simpler logic and better layout in phones. Fix bug in generated images, add convenient classes. The output of some images was a generator instead of an URL. I add excerpt-txt and excerpt-img classes for make life easier for themes. Add basic styling. All images now have the same height, and excerpts are 80 words long, which mostly matches the image height. Update for upstream module rename. * OCA Transbot updated translations from Transifex * [9.0][website_blog_excerpt_img] Migrate, LGPL. Relicensed, migrated, new tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relicensed, migrated, transbot squashed.
@Tecnativa