[10.0] Fix base_kanban_stage tests#762
Merged
Merged
Conversation
This was referenced Mar 6, 2017
Closed
moylop260
approved these changes
Mar 6, 2017
Contributor
|
@obulkin - please take a look |
obulkin
approved these changes
Mar 6, 2017
obulkin
left a comment
obulkin
left a comment
Contributor
There was a problem hiding this comment.
👍 Looks good to me. enter_test_mode() makes some changes to the registry class that probably persist between test suites if they're not reversed by leave_test_mode(): https://github.com/odoo/odoo/blob/10.0/odoo/modules/registry.py#L435
lasley
approved these changes
Mar 6, 2017
Contributor
|
Thanks @florian-dacosta |
Contributor
|
@florian-dacosta - Did you plan on backporting to v9? |
Contributor
Author
|
@lasley |
Contributor
|
Awesome, thanks again @florian-dacosta! |
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (8.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think there is a problem with base_kanban_stage tests, as it never leaves the test mode :
https://github.com/OCA/server-tools/blob/10.0/base_kanban_stage/tests/test_base_kanban_abstract.py#L47
Tests in other module may fail because of that.