Skip to content

[10.0] Add base_kanban_stage_state: Map stages to states#760

Merged
moylop260 merged 4 commits into
OCA:10.0from
LasLabs:base-kanban-stage-state
Mar 13, 2017
Merged

[10.0] Add base_kanban_stage_state: Map stages to states#760
moylop260 merged 4 commits into
OCA:10.0from
LasLabs:base-kanban-stage-state

Conversation

@kellylougheed

Copy link
Copy Markdown

Adds a new module, base_kanban_stage_state, which maps the stages from base_kanban_stage to states.

@kellylougheed
kellylougheed force-pushed the base-kanban-stage-state branch from bad9979 to fdb5444 Compare March 6, 2017 16:23
@lasley

lasley commented Mar 6, 2017

Copy link
Copy Markdown
Contributor

Build is failing due to #758

@lasley lasley added this to the 10.0 milestone Mar 6, 2017
Comment thread base_kanban_stage_state/README.rst Outdated
@@ -0,0 +1,60 @@
.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
:alt: License: AGPL-3

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch to LGPL-3.

Future reference, anything our LasLabs/SMD teams create should always be LGPL-3 unless we are depending on an AGPL-3 module.

Comment thread base_kanban_stage_state/README.rst Outdated
=======================

This module extends the functionality of base_kanban_stage to allow you to
map stages from base_kanban_stage to states.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Define the states

('draft', 'New'),
('open', 'In Progress'),
('pending', 'Pending'),
('done', 'Done'),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add ('exception', 'Exception')

@@ -0,0 +1,79 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the svg icon, we only need to provide the SVG if we edited or created. It's so that future maintainers can quickly make edits if need be. We have the SVG of this icon in the template module though, so we can save diff space.

@kellylougheed

Copy link
Copy Markdown
Author

Changes made @lasley

Comment thread base_kanban_stage_state/__manifest__.py Outdated
"category": "Base",
"website": "https://odoo-community.org/",
"author": "SMDrugstore, Odoo Community Association (OCA)",
"license": "AGPL-3",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGPL

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

from odoo import fields, models


_STATE = [

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, this should actually be an api.model method in base.kanban.stage - _get_states(). Allows for easier inheritance

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, should that be a separate PR since it's in a different module?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the question. That model is a few lines below this comment.

@lasley

lasley commented Mar 7, 2017

Copy link
Copy Markdown
Contributor

@kellylougheed - please rebase onto current OCA/10.0 to fix build (#762)

@kellylougheed
kellylougheed force-pushed the base-kanban-stage-state branch 2 times, most recently from fb22f8b to 0a70970 Compare March 8, 2017 17:54
@kellylougheed
kellylougheed force-pushed the base-kanban-stage-state branch from 0a70970 to 59c78ce Compare March 8, 2017 18:27
@kellylougheed

Copy link
Copy Markdown
Author

Changes made @lasley

@moylop260
moylop260 merged commit 032babc into OCA:10.0 Mar 13, 2017
@lasley
lasley deleted the base-kanban-stage-state branch March 13, 2017 17:34
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (14.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants