[9.0][IMP][base_custom_info] New types and access rules system. by yajo · Pull Request #492 · OCA/server-tools

yajo · 2016-08-03T15:20:40Z

Now you can define properties types, and access rules are inherited from the model/record linked to the custom info record.

@Tecnativa

pedrobaeza · 2016-08-03T22:36:27Z

Texts fields should be translatable. Can that be configurable in the definition? I don't think so, but maybe we can make some hack in the method fields_get or fields_view_get.

If not, we should define then the field as always translatable but include anyway a flag that allows to specify this translatable possibility. If you don't mark this flag, then at write time, you have to synchronize by code all the translations to the current one, so it behaves as if the field is not translatable in the background.

pedrobaeza · 2016-08-03T22:36:41Z

Why the test coverage drop?

pedrobaeza · 2016-08-03T22:37:06Z

 To define a template, you need to:

-* Go to *Settings > Custom Info > Templates*.
+* Go to *Custom Info > Templates*.


Is this a top level menu?

Isn't possible to put inside another top level menu? (we have enough top level menus already)

I realized that if you have access to setting the templates and values, you should be able to manage them from their menu more comfortably, no need to be an admin for that. Given in v9 the trend is to have more dedicated menus, I'm just following it. Besides, this base module isn't related to any other by default.

I guess the increase of top level menus comes from the enterprise version, where they are beautiful icons in a smartphone-like home panel. After all, the problem is that the backend community interface is way old-fashioned. Nobody will care about them if some day OCA creates a good alternative 😋

OK, but after this day comes, we have a lot of them... Anyway, if you don't find any parent menu, let's keep it this way. But we should provide then record rules to avoid one person without product access that modifies custom info profiles.

Forget about the record rule. You have answered me in other comment.

Note- mobile ready interface is scheduled in one of our sprints, so coming soon 😄

yajo · 2016-08-04T07:36:15Z

About coverage drop, I think it's because this module had no tests and it just got bigger.

I'd need some model to implement the custom.info mixin to test this. Do you have any idea on how to make the tests?

Can I declare a new model inside a test? Or do I create a transient model just for testing purposes, that does not appear anywhere else? But it would exist even in production databases...

pedrobaeza · 2016-08-04T07:42:01Z

Make it over res.users model.

pedrobaeza · 2016-08-04T07:42:30Z

Or even over res.partner. They are both models that are in the base module.

yajo · 2016-08-04T07:44:45Z

Good idea! 💡

pedrobaeza · 2016-08-04T12:15:21Z

Change spanish translation of the menu "Custom info" to "Inf. personalizada" to shorten the possible the menu width

pedrobaeza · 2016-08-04T12:47:38Z

    <field name="name">base.custom.info.value.tree</field>
    <field name="model">custom.info.value</field>
    <field name="arch" type="xml">
        <tree string="Custom Property Values">


Put create="0" delete="0" to avoid modifications on the populated list

Actually I thought that letting users put additional properties could help under some circumnstances. What do you think?

I don't think so. This will lead to conflicts (lines that doesn't belong to the same model), and it also break the concept of information template. If you need something extra, make another profile. The only problem I see with this that the same property can't be reused for several templates. Or it can be?

Not right now. I can add that to known issues.

BTW, this inability simplifies one algorithm. I'll commit soon.

yajo · 2016-08-04T15:44:42Z

This module should be ready, but there's a bug that me and @pedrobaeza found, that seems to affect v9 onchange methods.

When you choose a template from the partner form, it fills the values, but properties remain empty:

yajo · 2016-08-04T16:17:26Z

I honestly don't know why, but it seems to work now, after adding custom tree and form views inside the field.

Does anybody know how to disable the button "save & new" in the modal form?

lasley · 2016-08-04T16:18:31Z

+from openerp.tools.safe_eval import safe_eval


 class CustomInfoModelLink(models.AbstractModel):


~~Can we get these models in separate files please? Relevant guideline~~ Feel free to ignore me here, my bad didn't realize this wasn't a MIG for a second

lasley · 2016-08-04T16:29:22Z

@yajo does action_buttons="false" in the form tag declaration for the modal work? Admittedly never used it, but I found this code the other day, which seems to elude to what we want.

yajo · 2016-08-05T07:54:56Z

@lasley Seems impossible. I'd have to add the disable_multiple_selection somewhere, but options the form gets are hardcoded.

yajo · 2016-08-05T08:16:33Z

This should be ready to merge now.

lasley · 2016-08-05T15:48:48Z

Lame about the hardcoded form attrs. LGTM thanks @yajo 👍

pedrobaeza · 2016-08-08T09:19:55Z

    _name = "custom.info.value"
    _rec_name = 'value'
-    _order = "property_id"
+    _order = "name"


I think this should be ordered by a sequence defined in the template (not sortable at user level).

I like that.

yajo · 2016-08-08T09:40:26Z

I rebased to fix conflicts, and took the time to squash some commits. Sorry reviewers 😅. Notice that the really new 2 commits are the last 2.

yajo · 2016-12-16T08:28:47Z

That's because travis failures are from other addons, I rebased now, let's see if some get fixed.

lasley

Thanks @yajo - comments inline

PS big 👍 to the images

lasley · 2017-01-25T21:30:49Z

+            to_add = props_good - props_enabled
+            to_rm = props_enabled - props_good
+            # Remove remaining properties
+            # HACK https://github.com/odoo/odoo/pull/13480


This is merged, good to remove?

lasley · 2017-01-25T21:33:47Z

+        compute="_compute_dirty_templates",
+    )
+
+    # HACK https://github.com/odoo/odoo/pull/11042


Closed as no-fix. Probably good to remove the comment?

lasley · 2017-01-25T21:34:44Z

+                "dirty_templates").action_custom_info_templates_fill()
+        return res

+    # HACK https://github.com/odoo/odoo/pull/11042


Closed as no-fix. Probably good to remove the comment?

lasley · 2017-01-25T21:35:33Z

            info_values.unlink()
        return res
+
+    @api.one


Deprecated, please switch to multi

lasley · 2017-01-25T21:36:57Z

+    @api.multi
+    def all_custom_info_templates(self):
+        """Get all custom info templates involved in these owners."""
+        return (self.mapped("custom_info_template_id") |


Bitwise or, on a recordset?

This works as with normal python sets, joining all results and removing duplicates.

lasley · 2017-01-25T21:40:57Z

+                    self.default_value, self.field_type, self)
+            except ValueError:
+                selection = dict(
+                    self._fields["field_type"].get_description(self.env)


Missing a comma between this and next arg. Although why dict() instead of {}?

lasley · 2017-01-25T21:43:12Z

+        if "value" in vals:
+            self.env.context.skip_required = True
+        result = super(CustomInfoValue, self).create(vals)
+        # HACK https://github.com/odoo/odoo/pull/11042


closed nofix

lasley · 2017-01-25T21:43:21Z

+                .action_custom_info_templates_fill()
+        return result
+
+    # HACK https://github.com/odoo/odoo/pull/11042


closed nofix

lasley · 2017-01-25T21:44:07Z

+            s[s.field_name] = self._transform_value(
+                s.value, s.field_type, s.property_id)
+
+    @api.one


lasley · 2017-01-25T21:45:40Z

+    @api.onchange("property_id")
+    def _onchange_property_set_default_value(self):
+        """Load default value for this property."""
+        for record in self:


No need to rec loop in an onchange

yajo · 2017-02-13T08:16:29Z

-            value.ensure_one()
+            value = self.env["custom.info.option"].search([
+                ("property_ids", "in", properties.ids),
+                ("name", "ilike", u"%{}%".format(value)),


These percents do nothing, right? 🤔 (It's not =ilike)

Uhm, can be, I wasn't sure and put that for assuring.

* Now you can define properties types, and access rules are inherited from the model/record linked to the custom info record. * Simplified version of computed value. * Implement for res.partner. * Add tests and fix bugs discovered in the meantime. * Allow to disable partner custom info tab, and custom info menu. * All of it can be set within general settings. * Now, by default, this module does not display custom info for partners unless in demo mode. Better fit for a base module. * You can disable the top menu entry too if it disturbs you, or enable it for everybody. * Give a special form when editing in partner custom info tab. * Sortable properties. * Sort values at onchange time. * Improve performance in onchange. * Split in several model files.

- Select an option with an additional template and get it filled on the owner. - Drop support for onchange, too many bugs to workaround. - Improve demo data. - Improve tests. - Almost cool material icon, this is an app now! - Fun pics.

rafaelbn · 2017-04-05T10:22:07Z

@lasley could you review here last changes, your revision is blocking, thanks!
@yajo please check travis, is failing

yajo · 2017-04-19T08:03:51Z

I just tested this and it works like a charm now! I hope I can fix Travis soon & merge, awesome pals.

dreispt · 2017-04-20T12:21:15Z

I tried a Travis rebuild 🤞

yajo · 2017-05-29T16:16:26Z

It should go 💚 now.

Syncing from upstream OCA/server-tools (10.0)

yajo force-pushed the 9.0-base_custom_info-field_types branch from 2f981d9 to c59de8d Compare August 3, 2016 16:13

pedrobaeza reviewed Aug 3, 2016
View reviewed changes

pedrobaeza reviewed Aug 4, 2016
View reviewed changes

yajo force-pushed the 9.0-base_custom_info-field_types branch from ad15c7e to 9a88696 Compare August 4, 2016 15:43

lasley reviewed Aug 4, 2016
View reviewed changes

yajo mentioned this pull request Aug 5, 2016

[9.0][MIG][product_custom_info] Migrated to v9 OCA/product-attribute#177

Merged

1 task

pedrobaeza force-pushed the 9.0 branch from 8c5c4dd to 0d40d9b Compare August 5, 2016 16:07

pedrobaeza reviewed Aug 8, 2016
View reviewed changes

yajo force-pushed the 9.0-base_custom_info-field_types branch 2 times, most recently from 22d5676 to 736adbc Compare August 8, 2016 09:39

yajo force-pushed the 9.0-base_custom_info-field_types branch from 11fde67 to a379e16 Compare August 8, 2016 09:52

pedrobaeza mentioned this pull request Jan 18, 2017

Field One2many child propagation on NewId dict odoo/odoo#15129

Closed

lasley suggested changes Jan 25, 2017

View reviewed changes

pedrobaeza mentioned this pull request Feb 12, 2017

[FIX] web, models: issues in onchange o2m odoo/odoo#10557

Closed

pedrobaeza force-pushed the 9.0-base_custom_info-field_types branch 2 times, most recently from e87ec4a to 0c4e8a1 Compare February 13, 2017 01:32

yajo commented Feb 13, 2017

View reviewed changes

pedrobaeza force-pushed the 9.0-base_custom_info-field_types branch from 0c4e8a1 to 6c80dea Compare February 17, 2017 11:13

sergio-teruel force-pushed the 9.0-base_custom_info-field_types branch from a2939a0 to 0472dfe Compare April 3, 2017 07:26

yajo and others added 5 commits April 4, 2017 23:05

[CHG] base_custom_info: Relicense to LGPL with all authors' consent

231ef10

[IMP] base_custom_info: Recursive templates.

d0dfdc7

- Select an option with an additional template and get it filled on the owner. - Drop support for onchange, too many bugs to workaround. - Improve demo data. - Improve tests. - Almost cool material icon, this is an app now! - Fun pics.

[IMP] base_custom_info: Make backend UI work

4662877

[FIX] base_custom_info: fix demo template csv

65967a7

pedrobaeza force-pushed the 9.0-base_custom_info-field_types branch from c70bcf2 to 65967a7 Compare April 4, 2017 21:05

lasley approved these changes Apr 5, 2017

View reviewed changes

jesusVMayor pushed a commit to Comunitea/sale-workflow that referenced this pull request Apr 24, 2017

Workaround OCA/server-tools#492 (comment).

d1bcb45

pedrobaeza pushed a commit to Tecnativa/product-variant that referenced this pull request Apr 28, 2017

Workaround OCA/server-tools#492 (comment).

c2bf205

[FIX][base_custom_info] Make tests work

e2ccad4

pedrobaeza merged commit 50e9a8a into OCA:9.0 May 29, 2017

yajo deleted the 9.0-base_custom_info-field_types branch May 30, 2017 08:02

yajo mentioned this pull request Jan 31, 2018

[10.0] [MIG] base custom info #1115

Merged

Roodin pushed a commit to Comunitea/product-variant that referenced this pull request Jun 1, 2018

Workaround OCA/server-tools#492 (comment).

9eb2d51

pedrobaeza pushed a commit to Tecnativa/product-variant that referenced this pull request Aug 16, 2018

Workaround OCA/server-tools#492 (comment).

d796c1e

fuentes73 pushed a commit to Studio73/product-variant that referenced this pull request Oct 23, 2019

Workaround OCA/server-tools#492 (comment).

ac4d3c0

SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024

Merge pull request OCA#492 from OCA/10.0

f115426

Syncing from upstream OCA/server-tools (10.0)

		from openerp.tools.safe_eval import safe_eval


		class CustomInfoModelLink(models.AbstractModel):

Uh oh!

Uh oh!

Conversation

yajo commented Aug 3, 2016

Uh oh!

pedrobaeza commented Aug 3, 2016

Uh oh!

pedrobaeza commented Aug 3, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yajo commented Aug 4, 2016

Uh oh!

pedrobaeza commented Aug 4, 2016

Uh oh!

pedrobaeza commented Aug 4, 2016

Uh oh!

yajo commented Aug 4, 2016

Uh oh!

pedrobaeza commented Aug 4, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yajo commented Aug 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yajo commented Aug 4, 2016

Uh oh!

lasley Aug 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lasley commented Aug 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yajo commented Aug 5, 2016

Uh oh!

yajo commented Aug 5, 2016

Uh oh!

lasley commented Aug 5, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yajo commented Aug 8, 2016

Uh oh!

yajo commented Dec 16, 2016

Uh oh!

lasley left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yajo commented Aug 4, 2016 •

edited

Loading

lasley Aug 4, 2016 •

edited

Loading

lasley commented Aug 4, 2016 •

edited

Loading