Skip to content

[10.0] [MIG] base custom info#1115

Merged
pedrobaeza merged 7 commits into
OCA:10.0from
fanha99:10.0-mig-base_custom_info
Nov 21, 2018
Merged

[10.0] [MIG] base custom info#1115
pedrobaeza merged 7 commits into
OCA:10.0from
fanha99:10.0-mig-base_custom_info

Conversation

@fanha99

@fanha99 fanha99 commented Dec 30, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

almost change nothing from 9.0

yajo and others added 6 commits December 30, 2017 23:30
@yajo @fanha99
[CHG] base_custom_info: Relicense to LGPL with all authors' consent
298f75a 
# Conflicts:
#	base_custom_info/__manifest__.py
@yajo @fanha99
[IMP]base_custom_info: New types and access rules system.
4378c7d 
* Now you can define properties types, and access rules are inherited from the model/record
  linked to the custom info record.
* Simplified version of computed value.
* Implement for res.partner.
* Add tests and fix bugs discovered in the meantime.
* Allow to disable partner custom info tab, and custom info menu.
* All of it can be set within general settings.
* Now, by default, this module does not display custom info for partners unless in demo mode.
  Better fit for a base module.
* You can disable the top menu entry too if it disturbs you, or enable it for everybody.
* Give a special form when editing in partner custom info tab.
* Sortable properties.
* Sort values at onchange time.
* Improve performance in onchange.
* Split in several model files.

# Conflicts:
#	base_custom_info/__manifest__.py
#	base_custom_info/i18n/es.po
@yajo @fanha99
[IMP] base_custom_info: Recursive templates.
fa4e40d 
- Select an option with an additional template and get it filled on the owner.
- Drop support for onchange, too many bugs to workaround.
- Improve demo data.
- Improve tests.
- Almost cool material icon, this is an app now!
- Fun pics.

# Conflicts:
#	base_custom_info/__manifest__.py
@pedrobaeza @fanha99
[IMP] base_custom_info: Make backend UI work
be29d1b 
# Conflicts:
#	base_custom_info/i18n/es.po
@sergio-teruel @fanha99
[FIX] base_custom_info: fix demo template csv
6ab5a97
@yajo @fanha99
[FIX][base_custom_info] Make tests work
fb8b9c7
@pedrobaeza pedrobaeza added this to the 10.0 milestone Jan 1, 2018
@pedrobaeza

pedrobaeza commented Jan 1, 2018

Copy link
Copy Markdown
Member

Please check Travis status

@pedrobaeza pedrobaeza mentioned this pull request Jan 1, 2018
Closed
63 tasks
@yajo

yajo commented Jan 30, 2018

Copy link
Copy Markdown
Member

Wouldn't it be better to leave all as LGPL for an addon such as this one? 🤔

@pedrobaeza

pedrobaeza commented Jan 30, 2018

Copy link
Copy Markdown
Member

Module is LGPL already, but I think we missed to change manifest key.

@fanha99

fanha99 commented Jan 30, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hi all, in this example of readme: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-10.0
There is AGPL. There module in version 9 is LGPL.
Am I need to switch back to LGPL?
Edit: correct the version number.

@pedrobaeza

pedrobaeza commented Jan 30, 2018

Copy link
Copy Markdown
Member

I think so

@fanha99
fanha99 force-pushed the 10.0-mig-base_custom_info branch from 9486f79 to b6a9175 Compare January 30, 2018 15:22
@fanha99

fanha99 commented Jan 30, 2018

Copy link
Copy Markdown
Contributor Author

Hi all, switch back to LGPL as v9.
please help to review.

@fanha99

fanha99 commented Jan 30, 2018

Copy link
Copy Markdown
Contributor Author

@yajo : I'm working this module for v11.
I got the same problem: "When you choose a template from the partner form, it fills the values, but properties remain empty" is there any hint to fix it?

@yajo

yajo commented Jan 31, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

@fanha99 I remember problems with onchange implementation. It was supposedly fixed in Odoo itself, although in the mean time we managed to get a workaround. Read from #492 (comment) onwards, all I can say to you must be there.

OTOH, it's easier to discuss on the v11 PR, with runbot & so on. Let's focus on finishing this one and then you can open the v11 and we can talk on that if you like.

leemannd
leemannd suggested changes Mar 15, 2018
View reviewed changes

@leemannd leemannd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicking, but averall work looks good to me.
Thanks!

Comment thread base_custom_info/__manifest__.py Outdated
Comment thread base_custom_info/__init__.py Outdated
TelmoSenseFly
TelmoSenseFly reviewed Mar 15, 2018
View reviewed changes
Comment thread base_custom_info/models/custom_info_property.py Outdated
@leemannd

leemannd commented Mar 15, 2018

Copy link
Copy Markdown
Contributor

@TelmoSenseFly Not sure it can be merged now. We have internal testing coming tomorrow.
Do you want the release to be done without it, or shall we wait for tomorrow?

@TelmoSenseFly

TelmoSenseFly commented Mar 15, 2018

Copy link
Copy Markdown

@leemannd No worries. It will be fine to wait for tomorrow.

@fanha99

fanha99 commented Apr 14, 2018

Copy link
Copy Markdown
Contributor Author

hi @leemannd , @TelmoSenseFly, could you please review again? thx.

@diggy128

diggy128 commented Nov 9, 2018

Copy link
Copy Markdown

Could this be merged?

@pedrobaeza

pedrobaeza commented Nov 9, 2018

Copy link
Copy Markdown
Member

I think this doesn't contain latest changes in v9.

@diggy128

diggy128 commented Nov 9, 2018 •
edited
Loading

Copy link
Copy Markdown

OK. Since I use this module along with other that depend on it, should I try to migrate it after a rebase?

@pedrobaeza

pedrobaeza commented Nov 9, 2018

Copy link
Copy Markdown
Member

OK

@fanha99

fanha99 commented Nov 21, 2018

Copy link
Copy Markdown
Contributor Author

I think this doesn't contain latest changes in v9.

could you please tell me which changes is it?

@pedrobaeza

pedrobaeza commented Nov 21, 2018

Copy link
Copy Markdown
Member

@fanha99 sorry, they are there. Please squash your 2 migration commits and I'll merge.

@fanha99
fanha99 force-pushed the 10.0-mig-base_custom_info branch from c71d9ab to b51d348 Compare November 21, 2018 09:09
@fanha99

fanha99 commented Nov 21, 2018

Copy link
Copy Markdown
Contributor Author

@pedrobaeza : done

@pedrobaeza
pedrobaeza merged commit 29721d0 into OCA:10.0 Nov 21, 2018
@fanha99
fanha99 deleted the 10.0-mig-base_custom_info branch November 22, 2018 04:33
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
@bt-admin
Merge pull request OCA#1115 from OCA/12.0
bc5fbd8 
Syncing from upstream OCA/server-tools (12.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yajo yajo yajo approved these changes
+2 more reviewers
@TelmoSenseFly TelmoSenseFly TelmoSenseFly left review comments
@leemannd leemannd leemannd approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs review

Projects

None yet

Milestone

10.0

Development

Successfully merging this pull request may close these issues.

7 participants

@fanha99 @pedrobaeza @yajo @leemannd @TelmoSenseFly @diggy128 @sergio-teruel