Skip to content

[13.0][IMP]bi_sql_editor: many2one fields clickable on the list view if setting is enabled - #892

Closed
GuillemCForgeFlow wants to merge 1 commit into
OCA:13.0from
ForgeFlow:13.0-imp-bi_sql_editor-many2one_fields_clickable
Closed

[13.0][IMP]bi_sql_editor: many2one fields clickable on the list view if setting is enabled#892
GuillemCForgeFlow wants to merge 1 commit into
OCA:13.0from
ForgeFlow:13.0-imp-bi_sql_editor-many2one_fields_clickable

Conversation

@GuillemCForgeFlow

Copy link
Copy Markdown
Contributor

@GuillemCForgeFlow

Copy link
Copy Markdown
Contributor Author

@legalsylvain perhaps you can give me some feedback on this one as well 🙂

Comment thread bi_sql_editor/views/view_bi_sql_view.xml Outdated
@GuillemCForgeFlow
GuillemCForgeFlow force-pushed the 13.0-imp-bi_sql_editor-many2one_fields_clickable branch from 021ec77 to 53d0a05 Compare June 4, 2024 15:33

@BernatPForgeFlow BernatPForgeFlow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test on Guillem's computer 💻 🙂

@GuillemCForgeFlow

Copy link
Copy Markdown
Contributor Author

@legalsylvain it would be nice to also get your input on this feature whenever you can 🙂

@legalsylvain

Copy link
Copy Markdown
Contributor

Hi thanks for the ping !

In fact, I don't understand what is widget="many2one". I rgrepped Odoo, and there is only a fiew occurences in the whole project. Coud you elaborate what is changing ?

@GuillemCForgeFlow

Copy link
Copy Markdown
Contributor Author

Hi thanks for the ping !

In fact, I don't understand what is widget="many2one". I rgrepped Odoo, and there is only a fiew occurences in the whole project. Coud you elaborate what is changing ?

Sure, it is actually a widget added in odoo's core. See here: https://github.com/odoo/odoo/blob/13.0/addons/web/static/src/js/fields/relational_fields.js#L96 and here https://github.com/odoo/odoo/blob/13.0/addons/web/static/src/js/fields/field_registry.js#L72.

It's not widely used, but it gives the possibility for Many2one records to be clickable so you can access the specific record.

@legalsylvain legalsylvain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I just tested on runboat :

checkbox disabled :

image

checkbox enabled :

image

(Add possibility to click on the company to enter in the company form).

Well, I'm not very in favor of adding another extra setting (extra column in the configuration of the view of bi.sql.view.field model).

Why not just install the OCA/web module web_tree_many2one_clickable
(https://github.com/OCA/web/tree/16.0/web_tree_many2one_clickable)

What do you think ?

thanks !

@GuillemCForgeFlow

Copy link
Copy Markdown
Contributor Author

Well, I just tested on runboat :

checkbox disabled :

image

checkbox enabled :

image

(Add possibility to click on the company to enter in the company form).

Well, I'm not very in favor of adding another extra setting (extra column in the configuration of the view of bi.sql.view.field model).

Why not just install the OCA/web module web_tree_many2one_clickable (https://github.com/OCA/web/tree/16.0/web_tree_many2one_clickable)

What do you think ?

thanks !

Understandable, I agree we can still use the https://github.com/OCA/web/tree/16.0/web_tree_many2one_clickable module if needed. We can close it 👍🏿

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants