Skip to content

[17.0][IMP]bi_sql_editor: many2one fields clickable on the list view if setting is enabled - #1079

Merged
OCA-git-bot merged 1 commit into
OCA:17.0from
ForgeFlow:17.0-imp-bi_sql_editor-m2o-clickable
Oct 27, 2025
Merged

[17.0][IMP]bi_sql_editor: many2one fields clickable on the list view if setting is enabled#1079
OCA-git-bot merged 1 commit into
OCA:17.0from
ForgeFlow:17.0-imp-bi_sql_editor-m2o-clickable

Conversation

@AndreuOForgeFlow

Copy link
Copy Markdown

(cherry picked from commit 53d0a05)

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @legalsylvain,
some modules you are maintaining are being modified, check this out!

@AndreuOForgeFlow
AndreuOForgeFlow force-pushed the 17.0-imp-bi_sql_editor-m2o-clickable branch 2 times, most recently from c4656d0 to 594320d Compare October 17, 2025 08:30
@AndreuOForgeFlow
AndreuOForgeFlow marked this pull request as ready for review October 17, 2025 08:36
Comment thread bi_sql_editor/models/bi_sql_view_field.py Outdated
Comment thread bi_sql_editor/views/view_bi_sql_view.xml
Comment thread bi_sql_editor/models/bi_sql_view_field.py Outdated
@GuillemCForgeFlow

Copy link
Copy Markdown
Contributor

@legalsylvain I know we discussed this back in the day in #892. But I was thinking, with the changes now proposed, we should be able to include it in the module as a minor improvement.
WDYT?

@legalsylvain legalsylvain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting this feature !

Comment thread bi_sql_editor/models/bi_sql_view_field.py Outdated
@AndreuOForgeFlow
AndreuOForgeFlow force-pushed the 17.0-imp-bi_sql_editor-m2o-clickable branch from 594320d to 887df41 Compare October 17, 2025 14:34

@GuillemCForgeFlow GuillemCForgeFlow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏿

@JordiMForgeFlow JordiMForgeFlow left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code + functional 👍🏼

@GuillemCForgeFlow

Copy link
Copy Markdown
Contributor

@legalsylvain can we get this one merged by any chance? 🙂

@legalsylvain

Copy link
Copy Markdown
Contributor

/ocabot merge minor

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1079-by-legalsylvain-bump-minor, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit bfa145e into OCA:17.0 Oct 27, 2025
5 of 7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at ab41159. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow
MiquelRForgeFlow deleted the 17.0-imp-bi_sql_editor-m2o-clickable branch October 27, 2025 12:54
rrebollo pushed a commit to BinhexTeam/reporting-engine that referenced this pull request Apr 16, 2026
Signed-off-by legalsylvain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants