Compute jar module descriptors in parallel#57
Merged
marchermans merged 4 commits intoMcModLauncher:mainfrom Nov 26, 2023
Merged
Compute jar module descriptors in parallel#57marchermans merged 4 commits intoMcModLauncher:mainfrom
marchermans merged 4 commits intoMcModLauncher:mainfrom
Conversation
marchermans
approved these changes
Nov 26, 2023
This was referenced Nov 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To compute a module descriptor, we need to compute the package list, and that is often slow. So do it in parallel! (And defer computation of the module descriptor until it is actually needed).
Also added a new method to retrieve the provided services without computing the full module descriptor, for use in the
ModDirTransformerDiscoverer.Tested in ATM8.