Conversation
Can be used to skip assets/ and data/ folders for MC mods.
marchermans
left a comment
There was a problem hiding this comment.
In principal this is fine. But I have one thing to nitpick
|
Just out of curiosity: Can you run the JarModuleFinderBenchmark? I know the set of jars is not optimal for testing the speedup of parallel scanning, but I think they still provide some value. Overall, nice work! |
|
Default jar metadata implementations should be changed too to benefit from parallelization, that might save over 1s of startup in some cases based on some profiles from ATM8. |

I noted that building the module references was quite slow on the FC pack, so I propose these two simple changes:
assetsanddatamod files for JARs.ModuleReferences in parallel because why not.Performance numbers on the FC pack (single run per line so not super precise but VisualVM confirms the observations):