BE-6875 Additional changes to ingest KD folder data#135
Conversation
hleekeeper
requested review from
THeflinKeeper,
saldoukhov and
tylerccarson
as code owners
| parentKind: 'keeper_drive_folder', | ||
| childKind: 'record', | ||
| childUid: recordUid, | ||
| }) |
There was a problem hiding this comment.
❓ Why do we need this?
When a KD folder is removed, all its child resources should be wiped altogether. However, since the delete operation takes place before the dependency removal, when the record is removed from the folder, the folder data is already cleaned up and the consumer app fails to identify the kind based off of the uid. This will remove the burden of consumer apps figuring out the resource type out of the uid.
There was a problem hiding this comment.
I think this is such a good idea that it's maybe worth making this a breaking change (rather than string | RemovedDependency, make children just a set of RemovedDependency). The guessing we have to do on the BE side is no fun and probably caused some bugs. Something to consider (of course all the other dependency additions would have to be updated)
There was a problem hiding this comment.
yeah just wanted to avoid big changes. I'll create a Jira ticket for this tho https://keeper.atlassian.net/browse/BE-7544.
hleekeeper
changed the title
| parentKind: 'keeper_drive_folder', | ||
| childKind: 'record', | ||
| childUid: recordUid, | ||
| }) |
There was a problem hiding this comment.
I think this is such a good idea that it's maybe worth making this a breaking change (rather than string | RemovedDependency, make children just a set of RemovedDependency). The guessing we have to do on the BE side is no fun and probably caused some bugs. Something to consider (of course all the other dependency additions would have to be updated)
* minor change uid -> folderUid in the DKdFolderAccesst type * A removed dependency can now explicitly specify parentKind and childKind
* minor change uid -> folderUid in the DKdFolderAccesst type * A removed dependency can now explicitly specify parentKind and childKind
* BE-6955 Added new REST API callers keeperDriveRecordsAdd and keeperDriveRecordsUpdate (#123) * Updated the protobuf generation commands * Updated protobuf files * Added keeperDriveRecordsAdd and keeperDriveRecordsUpdate * Updated the protobufs * Ran format:check * fixed the wrong namespace used for the keeperDriveRecordsAdd caller * BE-6875 Support ingesting Keeper Drive records (#126) * Added isNil and toOptional * Added syncDown module * Support ingesting Keeper Drive records * fixed the broken unit tests * added a safety check * update * BE-6875 Support ingesting Keeper Drive folders (#128) * Added types DKdFolder, DKdFolderAccess, and DKdFolderSharingState * Added a method mapTeamKeyType * Ingest the Keeper Drive folder data * addressed a comment * Ingest keeper drive record links data (#129) * BE-6875 Added another optional param to the storage.delete function (#130) * Added another optional param to the storage.delete function * updated the code format * Handle removing the kd record links (#133) * Added the accessUid to the DKdFolderAccess type (#134) * BE-6875 Additional changes to ingest KD folder data (#135) * minor change uid -> folderUid in the DKdFolderAccesst type * A removed dependency can now explicitly specify parentKind and childKind * ingest non-shared-data for keeper drive items (#147) * Ingest the securityScoreData, securitData, and breachWatchRecords from the keeperDriveData (#150) Updated the getCounts to count the data in the keeperDriveData * Re-ran the protobug generation command
* BE-6955 Added new REST API callers keeperDriveRecordsAdd and keeperDriveRecordsUpdate (#123) * Updated the protobuf generation commands * Updated protobuf files * Added keeperDriveRecordsAdd and keeperDriveRecordsUpdate * Updated the protobufs * Ran format:check * fixed the wrong namespace used for the keeperDriveRecordsAdd caller * BE-6875 Support ingesting Keeper Drive records (#126) * Added isNil and toOptional * Added syncDown module * Support ingesting Keeper Drive records * fixed the broken unit tests * added a safety check * update * BE-6875 Support ingesting Keeper Drive folders (#128) * Added types DKdFolder, DKdFolderAccess, and DKdFolderSharingState * Added a method mapTeamKeyType * Ingest the Keeper Drive folder data * addressed a comment * Ingest keeper drive record links data (#129) * BE-6875 Added another optional param to the storage.delete function (#130) * Added another optional param to the storage.delete function * updated the code format * Handle removing the kd record links (#133) * Added the accessUid to the DKdFolderAccess type (#134) * BE-6875 Additional changes to ingest KD folder data (#135) * minor change uid -> folderUid in the DKdFolderAccesst type * A removed dependency can now explicitly specify parentKind and childKind * ingest non-shared-data for keeper drive items (#147) * Ingest the securityScoreData, securitData, and breachWatchRecords from the keeperDriveData (#150) Updated the getCounts to count the data in the keeperDriveData * Re-ran the protobug generation command
3 participants
No description provided.