BE-6875 Support ingesting Keeper Drive records#126
Merged
Conversation
hleekeeper
requested review from
THeflinKeeper,
saldoukhov and
tylerccarson
as code owners
hleekeeper
commented
Apr 21, 2026
| @@ -0,0 +1,3 @@ | |||
| export const createKdRecordAccessCompositeKey = (actorUid: string, recordUid: string) => `${actorUid}:${recordUid}` | |||
|
|
|||
| export const createKdFolderAccessCompositeKey = (actorUid: string, folderUid: string) => `${folderUid}:${actorUid}` | |||
Contributor
Author
There was a problem hiding this comment.
The sync down response doesn't include the index key for recordAccess and folderAccess, hence clients should generate composite key. I verified with KA team, and these are correct way to generate composite keys.
saldoukhov
approved these changes
Apr 21, 2026
THeflinKeeper
approved these changes
Apr 21, 2026
tylerccarson
approved these changes
Apr 21, 2026
hleekeeper
added a commit
that referenced
this pull request
May 29, 2026
* Added isNil and toOptional * Added syncDown module * Support ingesting Keeper Drive records * fixed the broken unit tests * added a safety check * update
hleekeeper
added a commit
that referenced
this pull request
Jun 8, 2026
* Added isNil and toOptional * Added syncDown module * Support ingesting Keeper Drive records * fixed the broken unit tests * added a safety check * update
hleekeeper
added a commit
that referenced
this pull request
Jun 8, 2026
* BE-6955 Added new REST API callers keeperDriveRecordsAdd and keeperDriveRecordsUpdate (#123) * Updated the protobuf generation commands * Updated protobuf files * Added keeperDriveRecordsAdd and keeperDriveRecordsUpdate * Updated the protobufs * Ran format:check * fixed the wrong namespace used for the keeperDriveRecordsAdd caller * BE-6875 Support ingesting Keeper Drive records (#126) * Added isNil and toOptional * Added syncDown module * Support ingesting Keeper Drive records * fixed the broken unit tests * added a safety check * update * BE-6875 Support ingesting Keeper Drive folders (#128) * Added types DKdFolder, DKdFolderAccess, and DKdFolderSharingState * Added a method mapTeamKeyType * Ingest the Keeper Drive folder data * addressed a comment * Ingest keeper drive record links data (#129) * BE-6875 Added another optional param to the storage.delete function (#130) * Added another optional param to the storage.delete function * updated the code format * Handle removing the kd record links (#133) * Added the accessUid to the DKdFolderAccess type (#134) * BE-6875 Additional changes to ingest KD folder data (#135) * minor change uid -> folderUid in the DKdFolderAccesst type * A removed dependency can now explicitly specify parentKind and childKind * ingest non-shared-data for keeper drive items (#147) * Ingest the securityScoreData, securitData, and breachWatchRecords from the keeperDriveData (#150) Updated the getCounts to count the data in the keeperDriveData * Re-ran the protobug generation command
sgaddala-ks
pushed a commit
that referenced
this pull request
Jun 12, 2026
* BE-6955 Added new REST API callers keeperDriveRecordsAdd and keeperDriveRecordsUpdate (#123) * Updated the protobuf generation commands * Updated protobuf files * Added keeperDriveRecordsAdd and keeperDriveRecordsUpdate * Updated the protobufs * Ran format:check * fixed the wrong namespace used for the keeperDriveRecordsAdd caller * BE-6875 Support ingesting Keeper Drive records (#126) * Added isNil and toOptional * Added syncDown module * Support ingesting Keeper Drive records * fixed the broken unit tests * added a safety check * update * BE-6875 Support ingesting Keeper Drive folders (#128) * Added types DKdFolder, DKdFolderAccess, and DKdFolderSharingState * Added a method mapTeamKeyType * Ingest the Keeper Drive folder data * addressed a comment * Ingest keeper drive record links data (#129) * BE-6875 Added another optional param to the storage.delete function (#130) * Added another optional param to the storage.delete function * updated the code format * Handle removing the kd record links (#133) * Added the accessUid to the DKdFolderAccess type (#134) * BE-6875 Additional changes to ingest KD folder data (#135) * minor change uid -> folderUid in the DKdFolderAccesst type * A removed dependency can now explicitly specify parentKind and childKind * ingest non-shared-data for keeper drive items (#147) * Ingest the securityScoreData, securitData, and breachWatchRecords from the keeperDriveData (#150) Updated the getCounts to count the data in the keeperDriveData * Re-ran the protobug generation command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.