Skip to content

Comments

Bs17 hugo docsy update#322

Open
stumbo wants to merge 29 commits intomainfrom
bs17_hugo_docsy_update
Open

Bs17 hugo docsy update#322
stumbo wants to merge 29 commits intomainfrom
bs17_hugo_docsy_update

Conversation

@stumbo
Copy link
Member

@stumbo stumbo commented Feb 22, 2026

Needs the readme updated. But getting close to complete.

README.md file updated.

Pickup minor bug fixes, security updates, etc.
Dark mode - we used custom colors and will need to rethink that
prior to implementing dark mode.
Move directory structure to match docsy preferred naming.
Fix image-gallery to reflect new location.
Cleanup image-gallery shortcode to use page resources.
Fixes issue with image placement on home page and brings css
in line with Docsy standards.
 - Remove unused parts of cover.html, simplify where possible.
 - Remove unused shortcodes.
Moved favicons to a standard location, regenerated them all from the
logoWindows.svg file.  Revised favicon.html to serve up the appropriate
icon.  .svg and .ico are preferred formats.
@stumbo stumbo self-assigned this Feb 22, 2026
@pamoroso
Copy link
Member

The new site works well in Firefox and Chrome on Linux and Android but I've notice a few issues.

With the dark theme the color of text in code blocks is nearly invisible because of the low contrast with the background. See for example here.

Also, when the window width on the desktop is short and I click > a few times to view the rest of items of the top menu, clicking < does nothing.

Finally, the Medley logo is missing from the annual report pages.

Copy link
Member

@masinter masinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perused the sources but didn't test.
but LGTM.

@hjellinek
Copy link
Contributor

I see dangling text/an open paren at the head of https://github.com/Interlisp/Interlisp.github.io/blob/main/content/en/history/bibliography/_index.md, which is not yet a file included in this PR.

(This bibliography is kept in sync with our [Zotero](https://www.zotero.org/) collection [Library](https://www.zotero.org/groups/2914042/interlisp/library).

I've never liked having two Zotero links in the sentence. Please change it to

We generate this from our [Zotero collection library](https://www.zotero.org/groups/2914042/interlisp/library).

Thanks.

@hjellinek
Copy link
Contributor

hjellinek commented Feb 22, 2026

Another "while you're in there":

I thought we'd agreed to eliminate the Feedback item on our pages, since no one looks at the Google Analytics data it feeds (if I remember correctly) and it's visually intrusive.

I propose eliminating it, or, if people still want it for some reason, making it much smaller.

See for instance the In Memoriam page, where it's more prominent than the prominent people:

screenshot_1174

Move logo from html <img/> to Hugo figure shortcode.  This fixes
the issues with the base url.
@pamoroso
Copy link
Member

After commit 052122d the Medley logo in the annual reports is not fixed on the staging site.

@pamoroso
Copy link
Member

At commit 5e15bd0 the Medley logo does show up on the 2025 annual report but the page also downloads the file U_65Ft2C.html: U_65Ft2C.html

The 2024 report shows a left brace { at the left of the Medley logo:

medley-logo

Removed the feedback buttons and the footer stating when the page
was last updated and the associated commit.
@stumbo stumbo force-pushed the bs17_hugo_docsy_update branch from 5abde22 to d275681 Compare February 23, 2026 12:47
@stumbo
Copy link
Member Author

stumbo commented Feb 23, 2026

Another "while you're in there":

I thought we'd agreed to eliminate the Feedback item on our pages, since no one looks at the Google Analytics data it feeds (if I remember correctly) and it's visually intrusive.

I propose eliminating it, or, if people still want it for some reason, making it much smaller.

I'm fine with eliminating it. I don't think we have ever gotten feedback from it. I've made the appropriate updates to the params.yaml file.

I also disabled the git commit information that was appearing at the bottom of the page. It might be useful for a developer, but serves no useful purpose to users of the site.

@stumbo
Copy link
Member Author

stumbo commented Feb 23, 2026

At commit 5e15bd0 the Medley logo does show up on the 2025 annual report but the page also downloads the file U_65Ft2C.html: U_65Ft2C.html

The 2024 report shows a left brace { at the left of the Medley logo:
medley-logo

At commit 5e15bd0 the Medley logo does show up on the 2025 annual report but the page also downloads the file U_65Ft2C.html: U_65Ft2C.html

The 2024 report shows a left brace { at the left of the Medley logo:
medley-logo

Thanks for the eagle eyes. I missed the extra left brace when editing. I think it should all be correct.

@stumbo
Copy link
Member Author

stumbo commented Feb 23, 2026

With the dark theme the color of text in code blocks is nearly invisible because of the low contrast with the background. See for example here.With the dark theme the color of text in code blocks is nearly invisible because of the low contrast with the background. See for example here.

This is a problem because the font color is custom. It matches our navbar color and the primary color on the home page. I can break that logic when dark mode is enabled and use a different font color. It's not at the top of my to-do list right now. If we feel this is a major flaw, we can disable dark mode and resolve this later.

Copy link
Member

@masinter masinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disable dark mode and resolve this later.

i'd rather have no dark mode than illegible dark mode

Copy link
Member

@pamoroso pamoroso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issues are now fixed except as noted.

@hjellinek
Copy link
Contributor

I based a new branch on this one with the change I proposed above. It's #323. I'd appreciate it if you @stumbo merged it into this PR.

* Update in-memoriam.md

Corrected grammar.

Signed-off-by: Herb Jellinek <jellinek@newscenter.com>

* Fix broken links to obituaries (#321)

Replace the broken links to the obituaries of Warren Teitelman and Daniel Bobrow with the corresponding links to the Wayback Machine captures.

Signed-off-by: Paolo Amoroso <info@paoloamoroso.com>

* This is the change I requested [here](#322 (comment)).

---------

Signed-off-by: Herb Jellinek <jellinek@newscenter.com>
Signed-off-by: Paolo Amoroso <info@paoloamoroso.com>
Co-authored-by: Paolo Amoroso <info@paoloamoroso.com>
@stumbo
Copy link
Member Author

stumbo commented Feb 24, 2026

Also, when the window width on the desktop is short and I click > a few times to view the rest of items of the top menu, clicking < does nothing.

This appears to be a problem in Docsy. I can recreate on their website. I will open an issue with them.

I don't feel this is a showstopper. There still is a horizontal scrollbar that can be used and, quite frankly, this seems like a tails case. Something that should be fixed but isn't going to diminish the overall experience for the majority of our users..

I'm going to move the PR out of draft and will hold off on merging it until there is concurrence with my opinion.

@stumbo stumbo marked this pull request as ready for review February 24, 2026 04:29
@stumbo
Copy link
Member Author

stumbo commented Feb 24, 2026

I based a new branch on this one with the change I proposed above. It's #323. I'd appreciate it if you @stumbo merged it into this PR.

Done

@pamoroso
Copy link
Member

@stumbo Right, the scroll behavior of < is an edge case and there is a workaround, so we can proceed without a fix.

We need to update the primary font color for dark mode before
enabling it.  The current default color does not provide enough
contrast with the dark background.
Reorganized and updated.
With the updated bibliography we no longer need to cache the
bibliography.json or the individual json files used to create
the final bibliography entries.  They have been removed and
the README updated to accurately reflect this portion of the build
process.
@stumbo stumbo force-pushed the bs17_hugo_docsy_update branch from 8282656 to ab942c8 Compare February 25, 2026 13:15
This fixes a regression in earlier changes within this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants